From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] jffs2: Fix serious write stall due to erase
Date: Tue, 12 Oct 2010 11:42:39 +0300 [thread overview]
Message-ID: <1286872959.2164.5.camel@localhost> (raw)
In-Reply-To: <1286467304-23370-1-git-send-email-Joakim.Tjernlund@transmode.se>
On Thu, 2010-10-07 at 18:01 +0200, Joakim Tjernlund wrote:
> Drop the alloc_sem before erasing flash in
> jffs2_garbage_collect_pass().
> Otherwise writes are put on hold until the erase
> has finised.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
>
> I am fairly sure it is safe to unlock the alloc_sem before
> calling jffs2_erase_pending_blocks(). Extra confirmation
> would be great though.
>
> This problem was introduced in 2.6.35
This looks safe for me as well, but I do not remember JFFS2 locking
rules anymore, so I'm not 100% sure. I've pushed your patch to my
l2-mtd-2.6.git.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-10-12 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 16:01 [PATCH] jffs2: Fix serious write stall due to erase Joakim Tjernlund
2010-10-09 16:36 ` Joakim Tjernlund
2010-10-12 8:42 ` Artem Bityutskiy [this message]
2010-10-12 8:55 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286872959.2164.5.camel@localhost \
--to=dedekind1@gmail.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.