From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] sound/soc: rename vol to volatile_register as appropriate Date: Wed, 13 Oct 2010 08:27:47 -0700 Message-ID: <1286983667.1117.347.camel@Joe-Laptop> References: <1286934472.1117.129.camel@Joe-Laptop> <20101013082414.GD6424@rakim.wolfsonmicro.main> <1286971846.1117.191.camel@Joe-Laptop> <20101013123301.GL6424@rakim.wolfsonmicro.main> <1286974549.1117.254.camel@Joe-Laptop> <20101013151117.GM6424@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101013151117.GM6424@rakim.wolfsonmicro.main> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Peter Hsiang , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Peter Ujfalusi , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Jesse Marroquin List-Id: alsa-devel@alsa-project.org On Wed, 2010-10-13 at 16:11 +0100, Mark Brown wrote: > On Wed, Oct 13, 2010 at 05:55:48AM -0700, Joe Perches wrote: > > Looking at the 2 register access routines where > > volatile_register/vol is used, I'd say those > > routines aren't useful at all and the checks > > should be inline instead. > If you check the code again you will notice that these functons are all > used in ops structures which presents obvious issues when trying to > replace with open coded checks. > I hope their usefulness is clear given the above. There is some value in using consistent function styles for table driven and non-table driven instances. > > > It's used as the field name for volatility in all the > > > drivers I can remember that use a table to look volatility up in > > > register properties. > > I did a grep for vol in sound, I found the uses > > where it was for volatile and patched them. > You're missing the "for this" here, I believe. To reiterate what I said > originally as far as I can remember every ASoC driver which uses a table > to look up volatility uses this naming. So all in this case means 3, 1 of which doesn't use it. I sent patches for them. The last patch saves ~3kb which I think is useful for ASoC. cheers, Joe