Re: list-modems patch

[Alexander A Khryukin <alexander@mezon.ru>]

[-- Attachment #1: Type: text/plain, Size: 2432 bytes --]

В Чтв, 14/10/2010 в 11:45 +0300, Marcel Holtmann пишет:
> Hi Alex,
> 
> > Sometimes i see 
> > 
> > [root(a)alexander-desktop ofono-0.31]# /usr/lib/ofono/test/list-modems 
> > [ /huawei5 ]
> >     Features = sim 
> >     Powered = 1
> >     Interfaces = org.ofono.Phonebook org.ofono.AudioSettings
> > org.ofono.VoiceCallManager org.ofono.SimManager 
> >     Online = 0
> >     Model = E1550
> >     Manufacturer = huawei
> >     Serial = 353142033084081
> >     Revision = 11.608.12.00.143
> >     [ org.ofono.Phonebook ]
> >     [ org.ofono.AudioSettings ]
> > Traceback (most recent call last):
> >   File "/usr/lib/ofono/test/list-modems", line 61, in <module>
> >     print "        %s = %s" % (key, val).encode('ascii')
> > 
> > 
> > Patch
> > 
> > 
> > 
> > diff --git a/test/list-modems b/test/list-modems
> > index 557efd5..df1dca8 100755
> > --- a/test/list-modems
> > +++ b/test/list-modems
> > @@ -58,6 +58,10 @@ for path, properties in modems:
> >                                         ")" for text, icon in
> > properties[key] ])
> >                         else:
> >                              	val = str(properties[key])
> > -                       print "        %s = %s" % (key, val)
> > +                       try:
> > +                               print  "       %s = %s" % (key, val)
> > +                       except:
> > +                               continue
> > +
> 
> can you at least print the key value. Just not printing that property at
> all is bad since it is there. Just marking the value as not printable
> seems to be the better approach.
> 
> Regards
> 
> Marcel
> 
> 
> 

Little fix

diff --git a/test/list-modems b/test/list-modems
index 557efd5..f8f10ac 100755
--- a/test/list-modems
+++ b/test/list-modems
@@ -58,6 +58,12 @@ for path, properties in modems:
                                        ")" for text, icon in
properties[key] ])
                        else:
                                val = str(properties[key])
-                       print "        %s = %s" % (key, val)
+                       try:
+                               print  "       %s = %s" % (key, val)
+                       except:
+                               print "Script mesaage:maybe wrong ASCII
characters\n"
+                       else:
+                               continue
+

        print