From: Gerald Schaefer <gerald.schaefer@de.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH] mutex: Introduce mutex_cpu_relax()
Date: Thu, 14 Oct 2010 19:31:05 +0200 [thread overview]
Message-ID: <1287077465.8344.47.camel@thinkpad> (raw)
In-Reply-To: <1287071960.29097.284.camel@twins>
On Do, 2010-10-14 at 17:59 +0200, Peter Zijlstra wrote:
> On Thu, 2010-10-14 at 17:33 +0200, Gerald Schaefer wrote:
>
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -100,6 +100,7 @@ config S390
> > select HAVE_KERNEL_BZIP2
> > select HAVE_KERNEL_LZMA
> > select HAVE_KERNEL_LZO
> > + select HAVE_MUTEX_CPU_RELAX
> > select ARCH_INLINE_SPIN_TRYLOCK
> > select ARCH_INLINE_SPIN_TRYLOCK_BH
> > select ARCH_INLINE_SPIN_LOCK
>
> >
> > +#ifndef HAVE_MUTEX_CPU_RELAX
> > +#define mutex_cpu_relax() cpu_relax()
> > +#endif
>
> Won't KConfig make CONFIG_HAVE_MUTEX_CPU_RELAX from that?
>
> Also, don't you have to first create a dummy Kconfig variable before you
> select it?
Of course you're right. I first used a #define in a header file,
but decided to rather use the Kconfig approach to avoid header
file dependency problems, should have been more careful with that.
I'll send a new patch.
next prev parent reply other threads:[~2010-10-14 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 15:33 [PATCH] mutex: Introduce mutex_cpu_relax() Gerald Schaefer
2010-10-14 15:55 ` Peter Zijlstra
2010-10-14 15:59 ` Peter Zijlstra
2010-10-14 17:31 ` Gerald Schaefer [this message]
2010-10-14 17:40 ` Gerald Schaefer
2010-10-14 22:13 ` Andrew Morton
2010-10-15 10:55 ` Gerald Schaefer
2010-10-15 11:07 ` [PATCH] mutex: Introduce arch_mutex_cpu_relax() Gerald Schaefer
2010-10-18 18:54 ` Peter Zijlstra
2010-10-19 12:24 ` Gerald Schaefer
2010-10-19 15:18 ` Gerald Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287077465.8344.47.camel@thinkpad \
--to=gerald.schaefer@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.