All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shane Shrybman <shrybman@teksavvy.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>,
	ivtv-devel@ivtvdriver.org,
	Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: Re: [GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio
Date: Sun, 17 Oct 2010 12:53:44 -0400	[thread overview]
Message-ID: <1287334424.3593.3.camel@mars> (raw)
In-Reply-To: <201010171243.39520.hverkuil@xs4all.nl>

On Sun, 2010-10-17 at 12:43 +0200, Hans Verkuil wrote:
> Hi Mauro,
> 
> I hope you can fast-track this to Linus! It's a nasty regression. From the log:
> 
> "The switch to the new control framework caused a regression where the audio was
> no longer unmuted after the carrier scan finished.
> 
> The original code attempted to set the volume control to its current value in
> order to have the set-volume control code to be called that handles the volume
> and muting. However, the framework will not call that code unless the new volume
> value is different from the old.
> 
> Instead we now call msp_s_ctrl directly.
> 
> It is a bit of a hack: we really need a v4l2_ctrl_refresh_ctrl function for this
> (or something along those lines).
> 
> Thanks to Andy Walls for bisecting this and to Shane Shrybman for reporting it!"
> 
> I've tested this with my PVR-350 and the audio is now working properly again.
> 

I've done a quick test of this patch on 2.6.36-rc8 and confirm it fixes
the no audio issue.

Thanks very much Andy and Hans.

Shane



  reply	other threads:[~2010-10-17 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 10:43 [GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio Hans Verkuil
2010-10-17 16:53 ` Shane Shrybman [this message]
2010-10-17 23:44 ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287334424.3593.3.camel@mars \
    --to=shrybman@teksavvy.com \
    --cc=awalls@md.metrocast.net \
    --cc=hverkuil@xs4all.nl \
    --cc=ivtv-devel@ivtvdriver.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.