From: Lin Ming <ming.m.lin@intel.com>
To: Len Brown <lenb@kernel.org>, Colin Ian King <colin.king@canonical.com>
Cc: "Moore, Robert" <robert.moore@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: ACPICA release 20101013 linuxized patches
Date: Mon, 18 Oct 2010 16:41:03 +0800 [thread overview]
Message-ID: <1287391263.2226.7.camel@localhost> (raw)
In-Reply-To: <alpine.LFD.2.00.1010180130360.3295@localhost.localdomain>
On Mon, 2010-10-18 at 13:31 +0800, Len Brown wrote:
> patch 5 doesn't look quite right,
> because it leaves both
>
> #define ACPI_BITMASK_PCIEXP_WAKE_STATUS 0x4000 /* ACPI 3.0 */
> and
> #define ACPI_BITMASK_PCIEXP_WAKE_DISABLE 0x4000 /* ACPI 3.0 */
>
> in aclocal.h
>
> If we're going to re-name what the original patch did,
> then we should finsh the job and delete the original name, yes?
No, we don't re-name anything.
#define ACPI_BITMASK_PCIEXP_WAKE_STATUS 0x4000 /* ACPI 3.0 */
#define ACPI_BITMASK_PCIEXP_WAKE_DISABLE 0x4000 /* ACPI 3.0 */
These are the bit positions for the status and enable registers.
Colin's original patch mis-used ACPI_BITMASK_PCIEXP_WAKE_DISABLE which
should be ACPI_BITMASK_PCIEXP_WAKE_STATUS, but it didn't cause any
problem because they have the same value 0x4000.
Bob has corrected it, see comment #1 at
http://www.acpica.org/bugzilla/show_bug.cgi?id=880
Lin Ming
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
prev parent reply other threads:[~2010-10-18 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-18 1:49 ACPICA release 20101013 linuxized patches Lin Ming
2010-10-18 5:31 ` Len Brown
2010-10-18 8:41 ` Lin Ming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287391263.2226.7.camel@localhost \
--to=ming.m.lin@intel.com \
--cc=colin.king@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.