From: Richard Purdie <rpurdie@linux.intel.com>
To: "Mei, Lei" <lei.mei@intel.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [PULL] at: Non root install patch is not necessary (Bug 246)
Date: Tue, 19 Oct 2010 13:02:35 +0100 [thread overview]
Message-ID: <1287489755.1720.1284.camel@rex> (raw)
In-Reply-To: <749B9D3DBF0F054390025D9EAFF47F222FE8FA5E@shsmsx501.ccr.corp.intel.com>
On Tue, 2010-10-19 at 17:07 +0800, Mei, Lei wrote:
> meta/recipes-extended/at/at_3.1.12.bb | 1
> meta/recipes-extended/at/files/nonrootinstall.patch | 75 --------------------
> 2 files changed, 76 deletions(-)
>
> Mei Lei (1):
> at: Non root install patch is not necessary (Bug 246) Pull URL:
>
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/distro
>
> commit 22a1491482bdd0b8fe1bac3f89a2b4dad0a94a8c
> Author: Mei Lei <lei.mei@intel.com>
> Date: Tue Oct 19 14:23:51 2010 +0800
>
> at: Non root install patch is not necessary (Bug 246)
>
> Removed nonrootinstall patch and modified the file which used this patch
>
> Fix [BUGID #246]
>
> Signed-off-by: Mei Lei <lei.mei@intel.com>
This change illustrates a problem we need to be very careful to watch
for when doing this. The patch you've removed not only handles root
install but also handles stripping of the binaries.
Note this bit:
-+ifeq ($(IROOT),)
- chown $(DAEMON_USERNAME):$(DAEMON_GROUPNAME) $(IROOT)$(LFILE)
-- test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) -o root -g $(DAEMON_GROUPNAME) -m 640 at.deny $(IROOT)$(etcdir)/
-- $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 6755 -s at $(IROOT)$(bindir)
-+endif
-+ test -f $(IROOT)$(etcdir)/at.allow || test -f $(IROOT)$(etcdir)/at.deny || $(INSTALL) $(INSTALLOWN) -m 600 at.deny $(IROOT)$(etcdir)/
-+ $(INSTALL) $(INSTALLOWN) -m 4755 at $(IROOT)$(bindir)
The -s option is removed from the install command.
Whilst we can remove the user ownership part of the patch, the -s option
needs to remain present as we expect unstripped binaries to be
installed.
Regards,
Richard
next prev parent reply other threads:[~2010-10-19 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 9:07 [PULL] at: Non root install patch is not necessary (Bug 246) Mei, Lei
2010-10-19 12:02 ` Richard Purdie [this message]
2010-10-20 9:05 ` Mei, Lei
2010-10-20 9:25 ` Richard Purdie
2010-10-21 5:17 ` Mei, Lei
2010-10-21 12:51 ` Richard Purdie
2010-10-21 17:27 ` [PULL] Fix at -- was Re: [PULL] at: Non root install patch is not necessary (Bug246) Mark Hatle
2010-10-22 9:26 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287489755.1720.1284.camel@rex \
--to=rpurdie@linux.intel.com \
--cc=lei.mei@intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.