From: Brian Gernhardt <brian@gernhardtsoftware.com>
To: Git List <git@vger.kernel.org>
Cc: Jakub Narebski <jnareb@gmail.com>,
Sven Verdoolaege <skimo@kotnet.org>,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2] t/gitweb-lib: Don't pass constant to decode_utf8
Date: Wed, 20 Oct 2010 01:57:11 -0400 [thread overview]
Message-ID: <1287554231-84196-1-git-send-email-brian@gernhardtsoftware.com> (raw)
Encode.pm started updating the string to decode in-place when a second
argument is passed in version 2.40. This causes 'decode_utf8("",
Encode::FB_CROAK)' to die with a message like:
Modification of a read-only value attempted at
/Library/Perl/Updates/5.10.0/darwin-thread-multi-2level/Encode.pm line
216.
Work around this by passing an empty variable instead of a constant
string.
Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
---
Changes since v1:
- Use an explicitly empty variable instead of $_
- Clearer commit message
- CC people who worked on t/gitweb-lib.sh
- based against maint
t/gitweb-lib.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index 81ef2a0..1b9523d 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -80,7 +80,7 @@ if ! test_have_prereq PERL; then
test_done
fi
-perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
+perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
skip_all='skipping gitweb tests, perl version is too old'
test_done
}
--
1.7.3.1.209.g52408
next reply other threads:[~2010-10-20 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 5:57 Brian Gernhardt [this message]
2010-10-20 19:05 ` [PATCH v2] t/gitweb-lib: Don't pass constant to decode_utf8 Jakub Narebski
2010-10-20 22:13 ` Brian Gernhardt
2010-10-20 22:28 ` Jakub Narebski
2010-10-20 23:07 ` [PATCH v3 (maint)] " Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287554231-84196-1-git-send-email-brian@gernhardtsoftware.com \
--to=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=skimo@kotnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.