From: Peter Zijlstra <peterz@infradead.org>
To: Bruno Randolf <br1@einfach.org>
Cc: randy.dunlap@oracle.com, akpm@linux-foundation.org,
kevin.granade@gmail.com, Lars_Ericsson@telia.com,
blp@cs.stanford.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Add generic exponentially weighted moving average (EWMA) function
Date: Wed, 20 Oct 2010 17:03:43 +0200 [thread overview]
Message-ID: <1287587023.3488.27.camel@twins> (raw)
In-Reply-To: <20101020082336.28281.77747.stgit@localhost6.localdomain6>
On Wed, 2010-10-20 at 17:23 +0900, Bruno Randolf wrote:
> +/**
> + * ewma_add() - Exponentially weighted moving average (EWMA)
> + * @avg: Average structure
> + * @val: Current value
> + *
> + * Add a sample to the average.
> + */
> +struct ewma*
> +ewma_add(struct ewma *avg, const unsigned int val)
> +{
> + avg->internal = avg->internal ?
> + (((avg->internal * (avg->weight - 1)) +
> + (val * avg->factor)) / avg->weight) :
> + (val * avg->factor);
> + return avg;
> +}
> +EXPORT_SYMBOL(ewma_add);
How can it be a weighted avg if each sample has the same weight?
next prev parent reply other threads:[~2010-10-20 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 8:23 [PATCH v3] Add generic exponentially weighted moving average (EWMA) function Bruno Randolf
2010-10-20 15:03 ` Peter Zijlstra [this message]
2010-10-21 5:40 ` Bruno Randolf
2010-10-21 10:04 ` Peter Zijlstra
2010-10-21 10:31 ` KOSAKI Motohiro
2010-10-22 0:53 ` Bruno Randolf
2010-10-22 1:11 ` KOSAKI Motohiro
2010-10-22 1:25 ` Bruno Randolf
2010-10-22 1:28 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287587023.3488.27.camel@twins \
--to=peterz@infradead.org \
--cc=Lars_Ericsson@telia.com \
--cc=akpm@linux-foundation.org \
--cc=blp@cs.stanford.edu \
--cc=br1@einfach.org \
--cc=kevin.granade@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.