From: Omar Ramirez Luna <omar.ramirez@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kalle Jokiniemi <kalle.jokiniemi@digia.com>,
Rajendra Nayak <rnayak@ti.com>,
Felipe Contreras <felipe.contreras@gmail.com>,
Tero Kristo <tero.kristo@nokia.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
Rene Sapiens <rene.sapiens@ti.com>,
Ernesto Ramos <ernesto@ti.com>,
linux-omap@vger.kernel.org, Paul Walmsley <paul@pwsan.com>
Subject: [PATCH 2/3] OMAP3: PM: update DSP reset code to use new SCM DSP boot control functions
Date: Fri, 22 Oct 2010 20:05:00 -0500 [thread overview]
Message-ID: <1287795901-28613-2-git-send-email-omar.ramirez@ti.com> (raw)
In-Reply-To: <1287795901-28613-1-git-send-email-omar.ramirez@ti.com>
From: Paul Walmsley <paul@pwsan.com>
Update the DSP reset code in pm34xx.c to use one of the new SCM DSP
boot control functions, omap2430_ctrl_set_dsp_bootmode().
This reset code should be moved out to a separate function to be
called by the hwmod reset process at some point. Also, 2430
should be initializing the DSP in a similar fashion.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
---
arch/arm/mach-omap2/pm34xx.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 8c8f1ac..b90b1fb 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -37,6 +37,7 @@
#include <plat/prcm.h>
#include <plat/gpmc.h>
#include <plat/dma.h>
+#include <plat/iva2_dsp.h>
#include <asm/tlbflush.h>
@@ -614,6 +615,7 @@ static struct platform_suspend_ops omap_pm_ops = {
* function forces the IVA2 into idle state so it can go
* into retention/off and thus allow full-chip retention/off.
*
+ * XXX This should be handled by the hwmod.
**/
static void __init omap3_iva_idle(void)
{
@@ -635,9 +637,7 @@ static void __init omap3_iva_idle(void)
cm_write_mod_reg(OMAP3430_CM_FCLKEN_IVA2_EN_IVA2_MASK,
OMAP3430_IVA2_MOD, CM_FCLKEN);
- /* Set IVA2 boot mode to 'idle' */
- omap_ctrl_writel(OMAP3_IVA2_BOOTMOD_IDLE,
- OMAP343X_CONTROL_IVA2_BOOTMOD);
+ omap2430_ctrl_set_dsp_bootmode(OMAP_IVA2_DSP_BOOTMODE_IDLE);
/* Un-reset IVA2 */
prm_write_mod_reg(0, OMAP3430_IVA2_MOD, OMAP2_RM_RSTCTRL);
--
1.7.1
next prev parent reply other threads:[~2010-10-23 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 1:04 [PATCH 1/3] OMAP: control: add functions for DSP boot address/mode control Omar Ramirez Luna
2010-10-23 1:05 ` Omar Ramirez Luna [this message]
2010-10-23 1:05 ` [PATCH 3/3] tidspbridge: convert OMAP3430 adaptation layer to use new SCM DSP boot control fns Omar Ramirez Luna
2010-10-26 5:43 ` Paul Walmsley
2010-10-26 14:00 ` Omar Ramirez Luna
[not found] <20101011203659.24425.2381.stgit@twilight.localdomain>
2010-10-11 20:37 ` [PATCH 2/3] OMAP3: PM: update DSP reset code to use new SCM DSP boot control functions Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287795901-28613-2-git-send-email-omar.ramirez@ti.com \
--to=omar.ramirez@ti.com \
--cc=ernesto@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=kalle.jokiniemi@digia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=rene.sapiens@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tero.kristo@nokia.com \
--cc=tony@atomide.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.