From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexey Fisher <bug-track@fisher-privat.net>
Subject: Re: Corruption in glxgears with Compiz
Date: Sat, 23 Oct 2010 10:23:19 +0200
Message-ID: <1287822199.5449.1.camel@zwerg>
References: <1287751996.19922.4.camel@pcjc2lap>
	<849307$a3hfvt@azsmga001.ch.intel.com>
	<1287774644.17191.9.camel@pcjc2lap>
	<5b55a1$ien4q1@fmsmga002.fm.intel.com>
	<1287804946.9701.3.camel@pcjc2lap>
	<1287806877.2423.3.camel@pcjc2lap>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail.gmx.net (mailout-de.gmx.net [213.165.64.22])
	by gabe.freedesktop.org (Postfix) with SMTP id 35E2F9E761
	for <intel-gfx@lists.freedesktop.org>;
	Sat, 23 Oct 2010 01:23:23 -0700 (PDT)
In-Reply-To: <1287806877.2423.3.camel@pcjc2lap>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Peter Clifton <pcjc2@cam.ac.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Am Samstag, den 23.10.2010, 05:07 +0100 schrieb Peter Clifton:
> On Sat, 2010-10-23 at 04:35 +0100, Peter Clifton wrote:
> 
> > Lost of bisecting and backporting later.. and I've identified the bad
> > commit:
> > 
> > 9220434a8768902cd9cf248709972678b74aa8c1 drm/i915: Only emit a flush
> > request on the active ring.
> 
> A minimal fix is this:
> 
> commit 78342e8fd01614ac0507db1f9c3e0522f4da3c14
> Author: Peter Clifton <pcjc2@cam.ac.uk>
> Date:   Sat Oct 23 04:00:21 2010 +0100
> 
>     Attempted fix
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 9290f02..868a399 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3759,7 +3759,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
>          */
>         dev->invalidate_domains = 0;
>         dev->flush_domains = 0;
> -       dev_priv->mm.flush_rings = 0;
> +       dev_priv->mm.flush_rings = ring->id;
>  
>         for (i = 0; i < args->buffer_count; i++) {
>                 struct drm_gem_object *obj = object_list[i];
> 
> 
> 
> 

Can only add here, me too.  This patch fix it on my board too.