From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Johannes Berg <johannes.berg@intel.com>,
Wey-Yi Guy <wey-yi.w.guy@intel.com>
Subject: [PATCH 2/8] iwlagn: don't resent RXON timing
Date: Sat, 23 Oct 2010 09:15:40 -0700 [thread overview]
Message-ID: <1287850546-23500-3-git-send-email-wey-yi.w.guy@intel.com> (raw)
In-Reply-To: <1287850546-23500-1-git-send-email-wey-yi.w.guy@intel.com>
From: Johannes Berg <johannes.berg@intel.com>
Resending RXON timing here caused issues with
dual-mode under certain circumstances, so avoid
doing it here right now.
This effectively reverts b01efe434bd6ea807eb72b
and partially 2491fa42d9bdf26075765. The next
patch will make all this cleaner for just the
devices that need it.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-agn.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index ad8754f..a126113 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -105,7 +105,6 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
int ret;
bool new_assoc =
!!(ctx->staging.filter_flags & RXON_FILTER_ASSOC_MSK);
- bool old_assoc = !!(ctx->active.filter_flags & RXON_FILTER_ASSOC_MSK);
if (!iwl_is_alive(priv))
return -EBUSY;
@@ -186,19 +185,6 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
iwl_set_rxon_hwcrypto(priv, ctx, !priv->cfg->mod_params->sw_crypto);
- if (!old_assoc) {
- /*
- * First of all, before setting associated, we need to
- * send RXON timing so the device knows about the DTIM
- * period and other timing values
- */
- ret = iwl_send_rxon_timing(priv, ctx);
- if (ret) {
- IWL_ERR(priv, "Error setting RXON timing!\n");
- return ret;
- }
- }
-
if (priv->cfg->ops->hcmd->set_pan_params) {
ret = priv->cfg->ops->hcmd->set_pan_params(priv);
if (ret)
--
1.7.0.4
next prev parent reply other threads:[~2010-10-23 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 16:15 [PATCH 0/8] update for 2.6.38 Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 1/8] iwlwifi: make mac80211 ops a device config Wey-Yi Guy
2010-10-23 16:15 ` Wey-Yi Guy [this message]
2010-10-25 8:34 ` [PATCH 2/8] iwlagn: don't resent RXON timing Johannes Berg
2010-10-23 16:15 ` [PATCH 3/8] iwlagn: new RXON processing for modern devices Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 4/8] iwlwifi: fix IBSS beaconing Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 5/8] iwlwifi: implement switching iftype while up Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 6/8] iwlagn: turn dynamic smps on while BT is on Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 7/8] iwlwifi: add new devices to Kconfig Wey-Yi Guy
2010-10-23 16:15 ` [PATCH 8/8] iwlagn: use 6000g2b uCode for 130 series devices Wey-Yi Guy
2010-11-09 21:12 ` [PATCH 0/8] update for 2.6.38 John W. Linville
2010-11-09 21:18 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287850546-23500-3-git-send-email-wey-yi.w.guy@intel.com \
--to=wey-yi.w.guy@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.