All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-mtd@lists.infradead.org,
	Mike Frysinger <vapier.adi@gmail.com>
Subject: Re: [PATCH v2 2/2] mtd-utils: nanddump: add 64-bit support, utilize libmtd
Date: Mon, 25 Oct 2010 22:20:27 +0300	[thread overview]
Message-ID: <1288034427.1865.9.camel@brekeke> (raw)
In-Reply-To: <1287645577-13538-3-git-send-email-computersforpeace@gmail.com>

On Thu, 2010-10-21 at 00:19 -0700, Brian Norris wrote:
> Adds support for 64-bit offsets (i.e., devices larger than 4GB).
> Utilizes the "unsigned long long" data type as the standard type
> for 64-bit offsets throughout. Reformats a few printf statements
> to avoid casting and to properly handle "long long."
> 
> Calls to ioctls are mostly replaced by libmtd interfaces (which should
> choose the proper ioctls for us); however, a few remain and probably
> should be handled with more robust interfaces, as some of these
> ioctls are considered "legacy."
> 
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> ---
>  nanddump.c |   83 +++++++++++++++++++++++++++++-------------------------------
>  1 files changed, 40 insertions(+), 43 deletions(-)

Pushed, thanks.

Mike, thanks for reviewing. You did not provide formal "Reviewed-by"
though, so I did not add this tag, assuming you did this for purposes,
because for other patches you provide ready to copy-paste tags.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)

  reply	other threads:[~2010-10-25 19:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20  6:45 [PATCH 1/2] mtd-utils: more style fixups Brian Norris
2010-10-20  6:45 ` [PATCH 2/2] mtd-utils: nanddump: add 64-bit support, utilize libmtd Brian Norris
2010-10-20  7:01   ` Mike Frysinger
2010-10-20 14:03     ` Brian Norris
2010-10-20 18:26       ` Mike Frysinger
2010-10-21  7:19     ` [PATCH v2 0/2] mtd-utils fixups Brian Norris
2010-10-21  7:19       ` [PATCH v2 1/2] mtd-utils: nanddump/nandwrite: style, signed-ness, printing fixups Brian Norris
2010-10-21  7:37         ` Mike Frysinger
2010-10-21 15:54           ` Brian Norris
2010-10-21 19:45             ` Mike Frysinger
2010-10-25 19:15         ` Artem Bityutskiy
2010-10-28  1:08           ` Brian Norris
2010-10-21  7:19       ` [PATCH v2 2/2] mtd-utils: nanddump: add 64-bit support, utilize libmtd Brian Norris
2010-10-25 19:20         ` Artem Bityutskiy [this message]
2010-10-25 19:54           ` Mike Frysinger
2010-10-26  9:45             ` Artem Bityutskiy
2010-10-21  7:37       ` [PATCH v2 0/2] mtd-utils fixups Mike Frysinger
2010-10-20  6:58 ` [PATCH 1/2] mtd-utils: more style fixups Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288034427.1865.9.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.