From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757436Ab0JZHH0 (ORCPT ); Tue, 26 Oct 2010 03:07:26 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:42069 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1754990Ab0JZHHZ (ORCPT ); Tue, 26 Oct 2010 03:07:25 -0400 X-Authenticated: #14349625 X-Provags-ID: V01U2FsdGVkX1+E/g4XkTOETjyD10XgEbMukHhbigKTQugJnWY1RC HNmcItSSkAOiUi Subject: [RFC/RFT PATCH v3] sched: automated per tty task groups From: Mike Galbraith To: Oleg Nesterov Cc: Peter Zijlstra , Mathieu Desnoyers , Ingo Molnar , Linus Torvalds , LKML , Markus Trippelsdorf In-Reply-To: <20101021162924.GA3225@redhat.com> References: <1287479765.9920.9.camel@marge.simson.net> <1287487757.24189.40.camel@marge.simson.net> <1287511983.7417.45.camel@marge.simson.net> <1287514410.7368.10.camel@marge.simson.net> <20101020025652.GB26822@elte.hu> <1287648715.9021.20.camel@marge.simson.net> <20101021105114.GA10216@Krystal> <1287660312.3488.103.camel@twins> <20101021162924.GA3225@redhat.com> Content-Type: text/plain Date: Tue, 26 Oct 2010 09:07:18 +0200 Message-Id: <1288076838.11930.1.camel@marge.simson.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-10-21 at 18:29 +0200, Oleg Nesterov wrote: > It is not clear to me why do we need rcu_read_lock() and how it can help. > The tty can go away right after dereferencing signal->tty. Which was Marcus' crash. Didn't happen here only because I didn't have CONFIG_PREEMPT set. Changes since v2: - drop