From: Luciano Coelho <luciano.coelho@nokia.com>
To: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: ext Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wl1271: Fix scan failure detection
Date: Tue, 26 Oct 2010 15:45:03 +0300 [thread overview]
Message-ID: <1288097103.27698.3.camel@chilepepper> (raw)
In-Reply-To: <1288095769.2607.34.camel@wimaxnb.nmp.nokia.com>
On Tue, 2010-10-26 at 14:22 +0200, Juuso Oikarinen wrote:
> On Tue, 2010-10-26 at 14:18 +0200, ext Johannes Berg wrote:
> > On Tue, 2010-10-26 at 15:01 +0300, Juuso Oikarinen wrote:
> > > On Tue, 2010-10-26 at 13:40 +0200, ext Johannes Berg wrote:
> >
> > > > > + if (wl->state == WL1271_STATE_OFF) {
> > > > > + /*
> > > > > + * We cannot return -EBUSY here because mac80211 will expect
> > > > > + * a call to ieee80211_scan_completed if we do - in this case
> > > > > + * there won't be any call.
> > > > > + */
> > > >
> > > > ???
> >
> > > I'll try explain what this is about. In net/wireless/sme.c you'll find
> > > this:
> >
> > [snip]
> >
> > so it's really about cfg80211, that explains my confusion :)
>
> Yeah, it seems it's my confusion :/
Thanks for the patch, Juuso. Thanks for the comment, Johannes.
I have reviewed this patch, changed the comment to cfg80211 and applied
to the wl12xx tree.
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
--
Cheers,
Luca.
next prev parent reply other threads:[~2010-10-26 12:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 11:24 [PATCH 1/2] wl1271: Fix scan failure detection juuso.oikarinen
2010-10-26 11:24 ` [PATCH 2/2] wl1271: Check interface state in op_* functions juuso.oikarinen
2010-10-26 12:42 ` Tuomas Katila
2010-10-26 12:45 ` Luciano Coelho
2010-10-26 11:40 ` [PATCH 1/2] wl1271: Fix scan failure detection Johannes Berg
2010-10-26 12:01 ` Juuso Oikarinen
2010-10-26 12:18 ` Johannes Berg
2010-10-26 12:22 ` Juuso Oikarinen
2010-10-26 12:45 ` Luciano Coelho [this message]
2010-10-26 12:40 ` Tuomas Katila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288097103.27698.3.camel@chilepepper \
--to=luciano.coelho@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.