RE: [PATCH 2/6] stemodem: add default case

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

Hi Mika,

> > > diff --git a/drivers/stemodem/radio-settings.c 
> > b/drivers/stemodem/radio-settings.c
> > > index 5b16ec0..a345975 100644
> > > --- a/drivers/stemodem/radio-settings.c
> > > +++ b/drivers/stemodem/radio-settings.c
> > > @@ -90,7 +90,7 @@ static gboolean 
> > ofono_mode_to_ste_mode(enum ofono_radio_access_mode mode,
> > >  	case OFONO_RADIO_ACCESS_MODE_UMTS:
> > >  		*stemode = STE_RADIO_WCDMA_ONLY;
> > >  		return TRUE;
> > > -	case OFONO_RADIO_ACCESS_MODE_LTE:
> > > +	default:
> > >  		break;
> > 
> > no default for enums please. I want the compiler to warn us about not
> > handled switch statements.
> 
> That must be a new policy then, considering that stemodem is the only one that failed compilation. Feel free to fix this one. The first two patches in the set are unrelated to fast dormancy anyway.

that is the whole point here. You modified the enum and the compilation
should fail unless you add a statement for that new item.

Let me make this clear, I do want the compilation to fail here and the
STE driver is doing the right thing.

There might be other cases where this is not consistent. I would prefer
if that never happens, but somethings things slip through even close
code review. If you know other cases, please let me know and we fix them
as well here.

Regards

Marcel