From: Darren Hart <dvhart@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Matt Fleming <matt@console-pimps.org>,
tglx@linutronix.de, peterz@infradead.org, mingo@elte.hu,
eric.dumazet@gmail.com, jkacur@redhat.com,
Darren Hart <dvhart@linux.intel.com>
Subject: [PATCH 1/3] futex: fix compiler warnings in exit_robust_list
Date: Wed, 27 Oct 2010 14:54:24 -0700 [thread overview]
Message-ID: <1288216466-14309-2-git-send-email-dvhart@linux.intel.com> (raw)
In-Reply-To: <1288216466-14309-1-git-send-email-dvhart@linux.intel.com>
The following commit introduced a compiler warning:
Commit 1dcc41bb037533839753df983d31778b30b67d93
futex: Change 3rd arg of fetch_robust_entry() to unsigned int*
The following archs/compiler versions all report:
kernel/futex.c: In function ‘exit_robust_list’:
kernel/futex.c:2492: warning: ‘next_pi’ may be used uninitialized in this function
x86_64
gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3
gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5
sh
sh-linux-gnu-gcc (Sourcery G++ Lite 4.3-143) 4.3.3
The code path really can't result in next_pi pi being unitialized (or should
not), but let's keep the build clean. Assign next_pi = 0 to avoid the warnings.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Tested-by: Matt Fleming <matt@console-pimps.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: John Kacur <jkacur@redhat.com>
---
kernel/futex.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/futex.c b/kernel/futex.c
index a118bf1..78715cb 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -2489,7 +2489,7 @@ void exit_robust_list(struct task_struct *curr)
{
struct robust_list_head __user *head = curr->robust_list;
struct robust_list __user *entry, *next_entry, *pending;
- unsigned int limit = ROBUST_LIST_LIMIT, pi, next_pi, pip;
+ unsigned int limit = ROBUST_LIST_LIMIT, pi, next_pi = 0, pip;
unsigned long futex_offset;
int rc;
--
1.7.1
next prev parent reply other threads:[~2010-10-27 21:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:54 [PATCH 0/3] futex: compiler warning and cleanups Darren Hart
2010-10-27 21:54 ` Darren Hart [this message]
2010-11-04 10:49 ` [1/3] futex: fix compiler warnings in exit_robust_list Uwe Kleine-König
2010-11-04 19:00 ` [PATCH V2] " Darren Hart
2010-11-10 12:20 ` Thomas Gleixner
[not found] ` <tip-4c115e951d80aff126468adaec7a6c7854f61ab8@git.kernel.org>
2010-11-10 16:14 ` [tip:core/urgent] futex: Address " Darren Hart
2010-11-10 20:16 ` Uwe Kleine-König
2010-11-10 20:21 ` Darren Hart
2010-11-10 20:22 ` Darren Hart
2010-10-27 21:54 ` [PATCH 2/3] futex: replace fshared and clockrt with combined flags Darren Hart
2010-11-08 16:47 ` Thomas Gleixner
2010-11-08 21:10 ` [PATCH V2] " Darren Hart
2010-10-27 21:54 ` [PATCH 3/3] futex: add futex_q static initializer Darren Hart
2010-11-08 16:42 ` Thomas Gleixner
2010-11-08 18:12 ` Peter Zijlstra
2010-11-08 19:39 ` Thomas Gleixner
2010-11-08 21:12 ` [PATCH V2] " Darren Hart
2010-11-08 21:40 ` [PATCH V3] " Darren Hart
2010-11-08 21:48 ` Thomas Gleixner
2010-11-08 21:59 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288216466-14309-2-git-send-email-dvhart@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.