From: Robert Love <robert.w.love@intel.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: devel@open-fcoe.org, linux-scsi@vger.kernel.org
Subject: Re: [Open-FCoE] [PATCH 2/2] libfc: fix memory leakage in local port
Date: Thu, 28 Oct 2010 16:13:28 -0700 [thread overview]
Message-ID: <1288307608.1431.203.camel@fritz> (raw)
In-Reply-To: <AANLkTikU6J5_uJ0k-EdmzKP0ORYrHkd1jdQjwY0B_jf-@mail.gmail.com>
On Wed, 2010-10-27 at 20:43 +0800, Hillf Danton wrote:
> There seems info should get freed when error encountered.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/drivers/scsi/libfc/fc_lport.c 2010-09-13 07:07:38.000000000 +0800
> +++ b/drivers/scsi/libfc/fc_lport.c 2010-10-27 20:35:10.000000000 +0800
> @@ -1707,8 +1707,10 @@ static int fc_lport_els_request(struct f
> info->sg = job->reply_payload.sg_list;
>
> if (!lport->tt.exch_seq_send(lport, fp, fc_lport_bsg_resp,
> - NULL, info, tov))
> + NULL, info, tov)) {
> + kfree(info);
The same comment I made about patch [1/2] applies here. We need the BSG
info in the fc_lport_bsg_resp response handler.
Thanks, //Rob
next prev parent reply other threads:[~2010-10-28 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 12:40 [PATCH 1/2] libfc: fix memory leakage in local port Hillf Danton
2010-10-27 12:43 ` [PATCH 2/2] " Hillf Danton
2010-10-28 23:13 ` Robert Love [this message]
2010-10-28 23:12 ` [Open-FCoE] [PATCH 1/2] " Robert Love
2010-10-28 23:31 ` Joe Eykholt
2010-10-28 23:35 ` Robert Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288307608.1431.203.camel@fritz \
--to=robert.w.love@intel.com \
--cc=devel@open-fcoe.org \
--cc=dhillf@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.