All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <steve@chygwyn.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] decnet: RCU conversion and get rid of dev_base_lock
Date: Fri, 29 Oct 2010 14:54:39 +0100	[thread overview]
Message-ID: <1288360479.9016.35.camel@dolmen> (raw)
In-Reply-To: <1288357764.2560.33.camel@edumazet-laptop>

Hi,

On Fri, 2010-10-29 at 15:09 +0200, Eric Dumazet wrote:
> While tracking dev_base_lock users, I found decnet used it in
> dnet_select_source(), but for a wrong purpose:
> 
> Writers only hold RTNL, not dev_base_lock, so readers must use RCU if
> they cannot use RTNL.
> 
> Adds an rcu_head in struct dn_ifaddr and handle proper RCU management.
> 
> Adds __rcu annotation in dn_route as well.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

I've not tested this, but I've read through it all and it seems good to
me.

Acked-by: Steven Whitehouse <swhiteho@redhat.com>

Steve.



  reply	other threads:[~2010-10-29 14:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 13:09 [PATCH] decnet: RCU conversion and get rid of dev_base_lock Eric Dumazet
2010-10-29 13:54 ` Steven Whitehouse [this message]
2010-11-08 21:43   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288360479.9016.35.camel@dolmen \
    --to=steve@chygwyn.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.