From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53576 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PDomy-0002Go-FN for qemu-devel@nongnu.org; Wed, 03 Nov 2010 21:38:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PDn0d-0005Z1-QI for qemu-devel@nongnu.org; Wed, 03 Nov 2010 19:44:52 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:46155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PDn0d-0005Yx-Gh for qemu-devel@nongnu.org; Wed, 03 Nov 2010 19:44:51 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oA3NYtJG003013 for ; Wed, 3 Nov 2010 17:34:55 -0600 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id oA3NinAQ244442 for ; Wed, 3 Nov 2010 17:44:50 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oA3Nmnle021331 for ; Wed, 3 Nov 2010 17:48:49 -0600 From: Adam Litke In-Reply-To: <1288798090-7127-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1288798090-7127-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 03 Nov 2010 18:44:46 -0500 Message-ID: <1288827886.2846.76.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][RESEND][PATCH v1 00/15] virtproxy: host/guest communication layer List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: abeekhof@redhat.com, agl@linux.vnet.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com You've got a lot of "objects" interacting with one another in virtproxy. I think it would help other reviewers if you could describe the relationships between the entities such as: VPDriver, VPConn, VPChannel, VPIForward, VPOForward, etc. This patch series is really wiring a lot of things together. Your documentation could end up as a nice ASCII art diagram and associated commentary at the top of virtproxy.c. -- Thanks, Adam