Re: [PATCH] leds-net5501: taints kernel, add license

[Richard Purdie <rpurdie@rpsys.net>]

On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
> 
> 	leds_net5501: module license 'unspecified' taints kernel.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Acked-by: Richard Purdie <rpurdie@linux.intel.com>

> ---
>  drivers/leds/leds-net5501.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
> 
> 
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
>  }
>  
>  arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
>