All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [RFC PATCH 1/3] modem: add modem online-offline watch
Date: Tue, 09 Nov 2010 19:31:53 +0900	[thread overview]
Message-ID: <1289298713.9615.208.camel@aeonflux> (raw)
In-Reply-To: <cb6fb563f8142ff4f4790d043d860a98f3bc2929.1289226246.git.Andras.Domokos@nokia.com>

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

Hi Andras,

> Signed-off-by: Andras Domokos <Andras.Domokos@nokia.com>

please redo the patches without the Signed-off-by line. It is mentioned
in doc/coding-style.txt that we do not use this.

Regards

Marcel



  reply	other threads:[~2010-11-09 10:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09  8:56 [PATCH 0/3] Emergency Calls (2nd round) Andras Domokos
2010-11-09  8:59 ` [RFC PATCH 1/3] modem: add modem online-offline watch Andras Domokos
2010-11-09 10:31   ` Marcel Holtmann [this message]
2010-11-09 14:26   ` Denis Kenzior
2010-11-09  8:59 ` [RFC PATCH 2/3] modem: add EmergencyMode property Andras Domokos
2010-11-09 14:37   ` Denis Kenzior
2010-11-10 14:14     ` Andras Domokos
2010-11-10 14:25       ` Denis Kenzior
2010-11-10 17:59         ` Marcel Holtmann
2010-11-09  9:00 ` [RFC PATCH 3/3] voicecall: add emergency call handling Andras Domokos
2010-11-09 14:52   ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289298713.9615.208.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.