From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755358Ab0KIKww (ORCPT ); Tue, 9 Nov 2010 05:52:52 -0500 Received: from darkcity.gna.ch ([195.226.6.51]:56910 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755169Ab0KIKwt convert rfc822-to-8bit (ORCPT ); Tue, 9 Nov 2010 05:52:49 -0500 X-Amavis-Alert: BAD HEADER SECTION, Improper folded header field made up entirely of whitespace (char 09 hex): Face: ...MWASAkVVViQjzP\n jycPrvgA\n\t\n R1goSzOnkp14Y[...] Subject: Re: Radeon RS780 - BUG: unable to handle kernel NULL pointer dereference From: Michel =?ISO-8859-1?Q?D=E4nzer?= To: Markus Trippelsdorf Cc: Thomas Hellstrom , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" In-Reply-To: <20101109103737.GA1767@arch.trippelsdorf.de> References: <20101108170221.GA1602@arch.trippelsdorf.de> <20101108170737.GA1617@arch.trippelsdorf.de> <20101108184301.GA1614@arch.trippelsdorf.de> <20101108190258.GA1623@arch.trippelsdorf.de> <4CD879BC.5060008@vmware.com> <20101109092920.GA1542@arch.trippelsdorf.de> <4CD91A07.1060308@vmware.com> <4CD91D58.7080508@vmware.com> <1289298777.10682.63.camel@thor.local> <20101109103737.GA1767@arch.trippelsdorf.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFDg4OHh4eLCwsOzs7S0tLWlpaa2treXl5hISEjY2NmJiYqKiotLS0xsbG1dXV/Pz81CO0SQAAArtJREFUOMtd1M9P01AcAHCI/4AtGq/QDfDHRfraEX8eaNeJFw1rO/DCYet7mxc1ZG0x3sStHQkmZpqtHDwAi+tMiFEzbZdwNWEJR48cjPG4g5HhELUbrHvjpYe2n7zvt++977cD/7rjsCry8uNG93Gge9OKUyAAgLB1AlpTZICmAzR15QTEiQAPAKADYLMPfhNnEJR4HvD0tT5YI2KGUcyqihQN7mDwZ3hMN4q2N4ol+gEGTSLWhorrjYXrGPwc0jTDOoKP4xi8G0W6adl2Gz6zGDwag5p5PMON7vZgJuSB976+3U6y2QdeKNet1+uum9/qwVQHvEjtKesY0EIb7CNYe+7DIRXCID/vQ4tksVAY7JFBD7yvqrWTL93xoUmOQsPIddbnuk8v+bBPsigB2KRlFxS4nL/owwEpKBSg2MU3UcDf+nATyyHEQwrHzJZFNpXeuOHDC0qW4sMhEHESFGOUrvgQpWUYFVNQdjQxca8abnSB55CmehdcLSxa1ifoQ4JBpmGYWbhsly3X0fxQ7xmkW3Y5CztLcXI+fAu2oWho3nbV6s5rH35xSC/aBR2tOpVa/Utv25tcTDPL6aT21kG17WrvaFtMBJmFhJCsVF4uu9VG76DWBaRnEiNs7pU659pYlfwtQSRy9GCYlwR7C6/dPQgBw3MsTPNWA4d9SeMDDC9JYdnqq/amdF+diGnVhXFztQ/2lJSWjulOxjRX+uC7EkOqhLRk2ejrqHVBEqCqJLO5cmEXgx8TrBiWVQh1u2DhzQlPsyIveU2YLGorGBxODoR5notlpcUieoLB1/NEmGc4AalGJpLe8WF/8txMWASAkVVViQjzP jycPrvgA R1goSzOnkp14YCYHsp7QJHAS5QcXDqG1jBxdSITVgBNkBTFloj88Q/gMkFcuItYiQPUCBGc2xh5drsD/wGZrgsgDOE4ZAAAAABJRU5ErkJggg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Tue, 09 Nov 2010 11:52:27 +0100 Message-ID: <1289299947.10682.68.camel@thor.local> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Die, 2010-11-09 at 11:37 +0100, Markus Trippelsdorf wrote: > On Tue, Nov 09, 2010 at 11:32:57AM +0100, Michel Dänzer wrote: > > On Die, 2010-11-09 at 11:07 +0100, Thomas Hellstrom wrote: > > > On 11/09/2010 10:53 AM, Thomas Hellstrom wrote: > > > > On 11/09/2010 10:29 AM, Markus Trippelsdorf wrote: > > > >> OK I've found the buggy commit by bisection: > > > >> > > > >> e376573f7267390f4e1bdc552564b6fb913bce76 is the first bad commit > > > >> commit e376573f7267390f4e1bdc552564b6fb913bce76 > > > >> Author: Michel Dänzer > > > >> Date: Thu Jul 8 12:43:28 2010 +1000 > > > >> > > > >> drm/radeon: fall back to GTT if bo creation/validation in VRAM > > > >> fails. > > > >> > > > >> This fixes a problem where on low VRAM cards we'd run out of > > > >> space for validation. > > > >> > > > >> [airlied: Tested on my M7, Thinkpad T42, compiz works with no > > > >> problems.] > > > >> > > > >> Signed-off-by: Michel Dänzer > > > >> Cc: stable@kernel.org > > > >> Signed-off-by: Dave Airlie > > > >> > > > >> Please note that this is an old commit from 2.6.36-rc. When I revert > > > >> it the > > > >> kernel no longer crashes. Instead I see the following in my dmesg: > > > >> > > > > > > > > Hmm, so this sounds like something in the Radeon eviction error path > > > > is causing corruption. > > > > I had a similar problem with vmwgfx, when I tried to unref a BO > > > > _after_ ttm_bo_init() failed. > > > > ttm_bo_init() is really supposed to call unref itself for various > > > > reasons, so calling unref() or kfree() after a failed ttm_bo_init() > > > > will cause corruption. > > > > > > > > In any case, the error below also suggests something is a bit fragile > > > > in the Radeon driver: > > > > > > > > First, an accelerated eviction may fail, like in the message below, > > > > but then there must always be a backup plan, like unaccelerated > > > > eviction to system. On BO creation, there are a number of placement > > > > strategies, but if all else fails, it should be possible to initially > > > > place the BO in system memory. > > > > > > > > Second, If bo validation fails during a command submission, due to > > > > insufficient VRAM / TT, then the driver should retry the complete > > > > validation cycle after first blocking all other validators and then > > > > evicting everything not pinned, to avoid failures due to fragmentation. > > > > > > > > /Thomas > > > > > > > > > > Indeed, it seems like the commit you mention just retries ttm_bo_init() > > > after it previously failed. At that point the bo has been destroyed, so > > > that is probably what's causing the BUG you are seeing. > > > > > > Admittedly, ttm_bo_init() calling unref on failure is not properly > > > documented in the function description. The reason for doing so is to > > > have a single path for freeing all BO resources already allocated on the > > > point of failure. > > > > Does the patch below fix the problem? > > Yes, indeed. I was just about to send the same patch to the list. > > Thanks. Thank you for testing / confirming the fix, and to Thomas for the analysis of the problem. I've submitted the fix to Dave with your Tested-by: added. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: Radeon RS780 - BUG: unable to handle kernel NULL pointer dereference Date: Tue, 09 Nov 2010 11:52:27 +0100 Message-ID: <1289299947.10682.68.camel@thor.local> References: <20101108170221.GA1602@arch.trippelsdorf.de> <20101108170737.GA1617@arch.trippelsdorf.de> <20101108184301.GA1614@arch.trippelsdorf.de> <20101108190258.GA1623@arch.trippelsdorf.de> <4CD879BC.5060008@vmware.com> <20101109092920.GA1542@arch.trippelsdorf.de> <4CD91A07.1060308@vmware.com> <4CD91D58.7080508@vmware.com> <1289298777.10682.63.camel@thor.local> <20101109103737.GA1767@arch.trippelsdorf.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 5587C9EFEA for ; Tue, 9 Nov 2010 02:52:49 -0800 (PST) In-Reply-To: <20101109103737.GA1767@arch.trippelsdorf.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Markus Trippelsdorf Cc: Thomas Hellstrom , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gRGllLCAyMDEwLTExLTA5IGF0IDExOjM3ICswMTAwLCBNYXJrdXMgVHJpcHBlbHNkb3JmIHdy b3RlOiAKPiBPbiBUdWUsIE5vdiAwOSwgMjAxMCBhdCAxMTozMjo1N0FNICswMTAwLCBNaWNoZWwg RMOkbnplciB3cm90ZToKPiA+IE9uIERpZSwgMjAxMC0xMS0wOSBhdCAxMTowNyArMDEwMCwgVGhv bWFzIEhlbGxzdHJvbSB3cm90ZTogCj4gPiA+IE9uIDExLzA5LzIwMTAgMTA6NTMgQU0sIFRob21h cyBIZWxsc3Ryb20gd3JvdGU6Cj4gPiA+ID4gT24gMTEvMDkvMjAxMCAxMDoyOSBBTSwgTWFya3Vz IFRyaXBwZWxzZG9yZiB3cm90ZToKPiA+ID4gPj4gT0sgSSd2ZSBmb3VuZCB0aGUgYnVnZ3kgY29t bWl0IGJ5IGJpc2VjdGlvbjoKPiA+ID4gPj4KPiA+ID4gPj4gZTM3NjU3M2Y3MjY3MzkwZjRlMWJk YzU1MjU2NGI2ZmI5MTNiY2U3NiBpcyB0aGUgZmlyc3QgYmFkIGNvbW1pdAo+ID4gPiA+PiBjb21t aXQgZTM3NjU3M2Y3MjY3MzkwZjRlMWJkYzU1MjU2NGI2ZmI5MTNiY2U3Ngo+ID4gPiA+PiBBdXRo b3I6IE1pY2hlbCBEw6RuemVyPGRhZW56ZXJAdm13YXJlLmNvbT4KPiA+ID4gPj4gRGF0ZTogICBU aHUgSnVsIDggMTI6NDM6MjggMjAxMCArMTAwMAo+ID4gPiA+Pgo+ID4gPiA+PiAgICAgIGRybS9y YWRlb246IGZhbGwgYmFjayB0byBHVFQgaWYgYm8gY3JlYXRpb24vdmFsaWRhdGlvbiBpbiBWUkFN IAo+ID4gPiA+PiBmYWlscy4KPiA+ID4gPj4KPiA+ID4gPj4gICAgICBUaGlzIGZpeGVzIGEgcHJv YmxlbSB3aGVyZSBvbiBsb3cgVlJBTSBjYXJkcyB3ZSdkIHJ1biBvdXQgb2YgCj4gPiA+ID4+IHNw YWNlIGZvciB2YWxpZGF0aW9uLgo+ID4gPiA+Pgo+ID4gPiA+PiAgICAgIFthaXJsaWVkOiBUZXN0 ZWQgb24gbXkgTTcsIFRoaW5rcGFkIFQ0MiwgY29tcGl6IHdvcmtzIHdpdGggbm8gCj4gPiA+ID4+ IHByb2JsZW1zLl0KPiA+ID4gPj4KPiA+ID4gPj4gICAgICBTaWduZWQtb2ZmLWJ5OiBNaWNoZWwg RMOkbnplcjxkYWVuemVyQHZtd2FyZS5jb20+Cj4gPiA+ID4+ICAgICAgQ2M6IHN0YWJsZUBrZXJu ZWwub3JnCj4gPiA+ID4+ICAgICAgU2lnbmVkLW9mZi1ieTogRGF2ZSBBaXJsaWU8YWlybGllZEBy ZWRoYXQuY29tPgo+ID4gPiA+Pgo+ID4gPiA+PiBQbGVhc2Ugbm90ZSB0aGF0IHRoaXMgaXMgYW4g b2xkIGNvbW1pdCBmcm9tIDIuNi4zNi1yYy4gV2hlbiBJIHJldmVydCAKPiA+ID4gPj4gaXQgdGhl Cj4gPiA+ID4+IGtlcm5lbCBubyBsb25nZXIgY3Jhc2hlcy4gSW5zdGVhZCBJIHNlZSB0aGUgZm9s bG93aW5nIGluIG15IGRtZXNnOgo+ID4gPiA+Pgo+ID4gPiA+Cj4gPiA+ID4gSG1tLCBzbyB0aGlz IHNvdW5kcyBsaWtlIHNvbWV0aGluZyBpbiB0aGUgUmFkZW9uIGV2aWN0aW9uIGVycm9yIHBhdGgg Cj4gPiA+ID4gaXMgY2F1c2luZyBjb3JydXB0aW9uLgo+ID4gPiA+IEkgaGFkIGEgc2ltaWxhciBw cm9ibGVtIHdpdGggdm13Z2Z4LCB3aGVuIEkgdHJpZWQgdG8gdW5yZWYgYSBCTyAKPiA+ID4gPiBf YWZ0ZXJfIHR0bV9ib19pbml0KCkgZmFpbGVkLgo+ID4gPiA+IHR0bV9ib19pbml0KCkgaXMgcmVh bGx5IHN1cHBvc2VkIHRvIGNhbGwgdW5yZWYgaXRzZWxmIGZvciB2YXJpb3VzIAo+ID4gPiA+IHJl YXNvbnMsICBzbyBjYWxsaW5nIHVucmVmKCkgb3Iga2ZyZWUoKSBhZnRlciBhIGZhaWxlZCB0dG1f Ym9faW5pdCgpIAo+ID4gPiA+IHdpbGwgY2F1c2UgY29ycnVwdGlvbi4KPiA+ID4gPgo+ID4gPiA+ IEluIGFueSBjYXNlLCB0aGUgZXJyb3IgYmVsb3cgYWxzbyBzdWdnZXN0cyBzb21ldGhpbmcgaXMg YSBiaXQgZnJhZ2lsZSAKPiA+ID4gPiBpbiB0aGUgUmFkZW9uIGRyaXZlcjoKPiA+ID4gPgo+ID4g PiA+IEZpcnN0LCBhbiBhY2NlbGVyYXRlZCBldmljdGlvbiBtYXkgZmFpbCwgbGlrZSBpbiB0aGUg bWVzc2FnZSBiZWxvdywgCj4gPiA+ID4gYnV0IHRoZW4gdGhlcmUgbXVzdCBhbHdheXMgYmUgYSBi YWNrdXAgcGxhbiwgbGlrZSB1bmFjY2VsZXJhdGVkIAo+ID4gPiA+IGV2aWN0aW9uIHRvIHN5c3Rl bS4gT24gQk8gY3JlYXRpb24sIHRoZXJlIGFyZSBhIG51bWJlciBvZiBwbGFjZW1lbnQgCj4gPiA+ ID4gc3RyYXRlZ2llcywgYnV0IGlmIGFsbCBlbHNlIGZhaWxzLCBpdCBzaG91bGQgYmUgcG9zc2li bGUgdG8gaW5pdGlhbGx5IAo+ID4gPiA+IHBsYWNlIHRoZSBCTyBpbiBzeXN0ZW0gbWVtb3J5Lgo+ ID4gPiA+Cj4gPiA+ID4gU2Vjb25kLCBJZiBibyB2YWxpZGF0aW9uIGZhaWxzIGR1cmluZyBhIGNv bW1hbmQgc3VibWlzc2lvbiwgZHVlIHRvIAo+ID4gPiA+IGluc3VmZmljaWVudCBWUkFNIC8gVFQs IHRoZW4gdGhlIGRyaXZlciBzaG91bGQgcmV0cnkgdGhlIGNvbXBsZXRlIAo+ID4gPiA+IHZhbGlk YXRpb24gY3ljbGUgYWZ0ZXIgZmlyc3QgYmxvY2tpbmcgYWxsIG90aGVyIHZhbGlkYXRvcnMgYW5k IHRoZW4gCj4gPiA+ID4gZXZpY3RpbmcgZXZlcnl0aGluZyBub3QgcGlubmVkLCB0byBhdm9pZCBm YWlsdXJlcyBkdWUgdG8gZnJhZ21lbnRhdGlvbi4KPiA+ID4gPgo+ID4gPiA+IC9UaG9tYXMKPiA+ ID4gPgo+ID4gPiAKPiA+ID4gSW5kZWVkLCBpdCBzZWVtcyBsaWtlIHRoZSBjb21taXQgeW91IG1l bnRpb24ganVzdCByZXRyaWVzIHR0bV9ib19pbml0KCkgCj4gPiA+IGFmdGVyIGl0IHByZXZpb3Vz bHkgZmFpbGVkLiBBdCB0aGF0IHBvaW50IHRoZSBibyBoYXMgYmVlbiBkZXN0cm95ZWQsIHNvIAo+ ID4gPiB0aGF0IGlzIHByb2JhYmx5IHdoYXQncyBjYXVzaW5nIHRoZSBCVUcgeW91IGFyZSBzZWVp bmcuCj4gPiA+IAo+ID4gPiBBZG1pdHRlZGx5LCB0dG1fYm9faW5pdCgpIGNhbGxpbmcgdW5yZWYg b24gZmFpbHVyZSBpcyBub3QgcHJvcGVybHkgCj4gPiA+IGRvY3VtZW50ZWQgaW4gdGhlIGZ1bmN0 aW9uIGRlc2NyaXB0aW9uLiAgVGhlIHJlYXNvbiBmb3IgZG9pbmcgc28gaXMgdG8gCj4gPiA+IGhh dmUgYSBzaW5nbGUgcGF0aCBmb3IgZnJlZWluZyBhbGwgQk8gcmVzb3VyY2VzIGFscmVhZHkgYWxs b2NhdGVkIG9uIHRoZSAKPiA+ID4gcG9pbnQgb2YgZmFpbHVyZS4KPiA+IAo+ID4gRG9lcyB0aGUg cGF0Y2ggYmVsb3cgZml4IHRoZSBwcm9ibGVtPwo+IAo+IFllcywgaW5kZWVkLiBJIHdhcyBqdXN0 IGFib3V0IHRvIHNlbmQgdGhlIHNhbWUgcGF0Y2ggdG8gdGhlIGxpc3QuCj4gCj4gVGhhbmtzLgoK VGhhbmsgeW91IGZvciB0ZXN0aW5nIC8gY29uZmlybWluZyB0aGUgZml4LCBhbmQgdG8gVGhvbWFz IGZvciB0aGUKYW5hbHlzaXMgb2YgdGhlIHByb2JsZW0uCgpJJ3ZlIHN1Ym1pdHRlZCB0aGUgZml4 IHRvIERhdmUgd2l0aCB5b3VyIFRlc3RlZC1ieTogYWRkZWQuCgoKLS0gCkVhcnRobGluZyBNaWNo ZWwgRMOkbnplciAgICAgICAgICAgfCAgICAgICAgICAgICAgICBodHRwOi8vd3d3LnZtd2FyZS5j b20KTGlicmUgc29mdHdhcmUgZW50aHVzaWFzdCAgICAgICAgIHwgICAgICAgICAgRGViaWFuLCBY IGFuZCBEUkkgZGV2ZWxvcGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==