From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627Ab0KJCbJ (ORCPT ); Tue, 9 Nov 2010 21:31:09 -0500 Received: from mail.perches.com ([173.55.12.10]:4898 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287Ab0KJCbG (ORCPT ); Tue, 9 Nov 2010 21:31:06 -0500 Subject: Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV From: Joe Perches To: Kristian =?ISO-8859-1?Q?H=F8gsberg?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: References: <4da8e82f773833e126fc5d2d5563093b784144e5.1289348757.git.joe@perches.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Nov 2010 18:31:03 -0800 Message-ID: <1289356263.28590.85.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-11-09 at 21:16 -0500, Kristian Høgsberg wrote: > On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches wrote: > > Using %pV reduces the number of printk calls and > > eliminates any possible message interleaving from > > other printk calls. > Wouldn't it be easier and more convenient to just make the %pV format > specifier just expect a format string and the va_arg list? Like this > printk(KERN_DEBUG "%pV", format, &args); > I mean, the %pV is kernel specific and we can just change how it works. No it wouldn't. gcc would now warn about a mismatch between format and arguments. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension %pV Date: Tue, 09 Nov 2010 18:31:03 -0800 Message-ID: <1289356263.28590.85.camel@Joe-Laptop> References: <4da8e82f773833e126fc5d2d5563093b784144e5.1289348757.git.joe@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.perches.com (mail.perches.com [173.55.12.10]) by gabe.freedesktop.org (Postfix) with ESMTP id C6FF1A028D for ; Tue, 9 Nov 2010 18:31:05 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Kristian =?ISO-8859-1?Q?H=F8gsberg?= Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDEwLTExLTA5IGF0IDIxOjE2IC0wNTAwLCBLcmlzdGlhbiBIw7hnc2Jlcmcgd3Jv dGU6Cj4gT24gVHVlLCBOb3YgOSwgMjAxMCBhdCA3OjM1IFBNLCBKb2UgUGVyY2hlcyA8am9lQHBl cmNoZXMuY29tPiB3cm90ZToKPiA+IFVzaW5nICVwViByZWR1Y2VzIHRoZSBudW1iZXIgb2YgcHJp bnRrIGNhbGxzIGFuZAo+ID4gZWxpbWluYXRlcyBhbnkgcG9zc2libGUgbWVzc2FnZSBpbnRlcmxl YXZpbmcgZnJvbQo+ID4gb3RoZXIgcHJpbnRrIGNhbGxzLgoKPiBXb3VsZG4ndCBpdCBiZSBlYXNp ZXIgYW5kIG1vcmUgY29udmVuaWVudCB0byBqdXN0IG1ha2UgdGhlICVwViBmb3JtYXQKPiBzcGVj aWZpZXIganVzdCBleHBlY3QgYSBmb3JtYXQgc3RyaW5nIGFuZCB0aGUgdmFfYXJnIGxpc3Q/ICBM aWtlIHRoaXMKPiAgIHByaW50ayhLRVJOX0RFQlVHICIlcFYiLCBmb3JtYXQsICZhcmdzKTsKPiBJ IG1lYW4sIHRoZSAlcFYgaXMga2VybmVsIHNwZWNpZmljIGFuZCB3ZSBjYW4ganVzdCBjaGFuZ2Ug aG93IGl0IHdvcmtzLgoKTm8gaXQgd291bGRuJ3QuCgpnY2Mgd291bGQgbm93IHdhcm4gYWJvdXQg YSBtaXNtYXRjaCBiZXR3ZWVuIGZvcm1hdCBhbmQgYXJndW1lbnRzLgoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=