From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h
Date: Wed, 10 Nov 2010 13:33:19 +0100 [thread overview]
Message-ID: <1289392399.2191.107.camel@laptop> (raw)
In-Reply-To: <20101110113106.11019.13707.stgit@e102109-lin.cambridge.arm.com>
On Wed, 2010-11-10 at 11:31 +0000, Catalin Marinas wrote:
> Commit 3e4d3af introduced the kmap_atomic_idx_push() function which
> warns on in_irq() with CONFIG_DEBUG_HIGHMEM enabled. This patch includes
> linux/hardirq.h for the in_irq definition.
Ah, indeed. The whole KS/LPC thing made me forget about this issue.
Somehow it only triggered on ARM.
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> include/linux/highmem.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index e913819..b676c58 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -5,6 +5,7 @@
> #include <linux/kernel.h>
> #include <linux/mm.h>
> #include <linux/uaccess.h>
> +#include <linux/hardirq.h>
>
> #include <asm/cacheflush.h>
>
>
prev parent reply other threads:[~2010-11-10 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 11:31 [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h Catalin Marinas
2010-11-10 12:33 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289392399.2191.107.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.