From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755787Ab0KJMlx (ORCPT ); Wed, 10 Nov 2010 07:41:53 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:48062 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1754148Ab0KJMlv (ORCPT ); Wed, 10 Nov 2010 07:41:51 -0500 X-Authenticated: #23875046 X-Provags-ID: V01U2FsdGVkX1/kysguEKzkztNtH2IIF3nWfAOg558/BJS/oVjsvm yOIMXINWW4V+Uf Subject: Re: [PATCH 2/2 v2] Unify rest of FAT messages. From: Alexey Fisher To: OGAWA Hirofumi Cc: linux-kernel@vger.kernel.org, joe@perches.com In-Reply-To: <87hbfppfu3.fsf@devron.myhome.or.jp> References: <1289321718-6373-1-git-send-email-bug-track@fisher-privat.net> <1289329470-14454-1-git-send-email-bug-track@fisher-privat.net> <87hbfppfu3.fsf@devron.myhome.or.jp> Content-Type: text/plain; charset="UTF-8" Date: Wed, 10 Nov 2010 13:41:48 +0100 Message-ID: <1289392908.6057.44.camel@zwerg> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 10.11.2010, 20:40 +0900 schrieb OGAWA Hirofumi: > Alexey Fisher writes: > > > Here is how it looks like after patch. > > This is going to unify the all FSes (e.g. fat_msg() uses fs_msg("FAT", ...))? > If so, I think it's welcome. If not, umm, it looks like good but... Yea, i thought about it. It will be better to have some kernel wide fs_msg(). But before doing this i think one more step should be done - some notification interface for userspace. If we get some fs errors userspace app should be notified so user too. I work currently on one case, user lost all data on FAT drive. First error messages was logged for some weeks, and only now some big data lost. There war no errors from GUI. --- Regards, Alexey