From: Liam Girdwood <lrg@slimlogic.co.uk>
To: abraham duenas <aduejazz@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] add missing comparison to strcmp call
Date: Wed, 10 Nov 2010 13:13:04 +0000 [thread overview]
Message-ID: <1289394784.3284.35.camel@odin> (raw)
In-Reply-To: <AANLkTi=Chhzawwe=84Z6K11TFi4hpe2d+zW4zNy49DLw@mail.gmail.com>
On Tue, 2010-11-09 at 15:43 -0600, abraham duenas wrote:
> >From f796e5f464d3454761b618912e5b4d14716c2bfc Mon Sep 17 00:00:00 2001
> From: abraham duenas <abraham.duenas@ti.com>
> Date: Tue, 9 Nov 2010 15:31:16 -0600
> Subject: [PATCH] add missing comparison to strcmp call
>
Could do with a little more description here.
>
> Signed-off-by: abraham duenas <abraham.duenas@ti.com>
> ---
> src/ucm/main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ucm/main.c b/src/ucm/main.c
> index e233f41..a73595d 100644
> --- a/src/ucm/main.c
> +++ b/src/ucm/main.c
> @@ -774,9 +774,9 @@ int snd_use_case_get_list(snd_use_case_mgr_t *uc_mgr,
> pthread_mutex_lock(&uc_mgr->mutex);
> if (strcmp(identifier, "_verbs") == 0)
> err = get_verb_list(uc_mgr, list);
> - else if (strcmp(identifier, "_enadevs"))
> + else if (strcmp(identifier, "_enadevs") == 0)
> err = get_enabled_device_list(uc_mgr, list);
> - else if (strcmp(identifier, "_enamods"))
> + else if (strcmp(identifier, "_enamods") == 0)
> err = get_enabled_modifier_list(uc_mgr, list);
> else {
> str1 = strchr(identifier, '/');
Looks fine to me, did this solve all your parsing issues ?
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-10 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 21:43 [PATCH] add missing comparison to strcmp call abraham duenas
2010-11-10 13:13 ` Liam Girdwood [this message]
2010-11-10 14:59 ` abraham duenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289394784.3284.35.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=aduejazz@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.