From: Richard Purdie <rpurdie@linux.intel.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: Poky <poky@lists.pokylinux.org>
Subject: Re: timestamp overkill?
Date: Wed, 10 Nov 2010 21:44:10 +0800 [thread overview]
Message-ID: <1289396650.1272.299.camel@rex> (raw)
In-Reply-To: <4CD29C94.4070301@mlbassoc.com>
On Thu, 2010-11-04 at 05:44 -0600, Gary Thomas wrote:
> I just noticed that there are two identical functions in image.bbclass
> to set/update the image timestamp. Why? Left over from a previous era?
>
> $ find meta* -name "*.bb*" -or -name "*.inc" | xargs grep create_etc_timestamp
> meta/classes/image.bbclass:create_etc_timestamp() {
> meta/classes/image.bbclass:# export the zap_root_password, create_etc_timestamp and remote_init_link
> meta/classes/image.bbclass:EXPORT_FUNCTIONS zap_root_password create_etc_timestamp remove_init_link do_rootfs make_zimage_symlink_relative set_image_autologin
> rootfs_update_timestamp rootfs_no_x_startup
>
> Notice that 'create_etc_timestamp' does not seem to be used by
> any recipe. Perhaps it should be removed?
The one that is unused should probably be removed. Please file a bug
and/or submit a patch!
Cheers,
Richard
next prev parent reply other threads:[~2010-11-10 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 11:44 timestamp overkill? Gary Thomas
2010-11-10 13:44 ` Richard Purdie [this message]
2010-11-10 14:09 ` Gary Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289396650.1272.299.camel@rex \
--to=rpurdie@linux.intel.com \
--cc=gary@mlbassoc.com \
--cc=poky@lists.pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.