From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37437 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PGDEY-0000PL-CT for qemu-devel@nongnu.org; Wed, 10 Nov 2010 11:09:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PGDEX-0004eq-HG for qemu-devel@nongnu.org; Wed, 10 Nov 2010 11:09:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PGDEX-0004ef-AC for qemu-devel@nongnu.org; Wed, 10 Nov 2010 11:09:13 -0500 Subject: Re: [Qemu-devel] [PATCH v2 RESEND] pc: e820 qemu_cfg tables need to be packed From: Alex Williamson In-Reply-To: References: <20101105214030.31799.12838.stgit@s20.home> Content-Type: text/plain; charset="UTF-8" Date: Wed, 10 Nov 2010 09:09:09 -0700 Message-ID: <1289405349.14321.93.camel@x201> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: jes.sorensen@redhat.com, qemu-devel@nongnu.org On Sun, 2010-11-07 at 14:59 +0000, Blue Swirl wrote: > On Fri, Nov 5, 2010 at 9:40 PM, Alex Williamson > wrote: > > We can't let the compiler define the alignment for qemu_cfg data. > > Actually, whole e820_table implementation seems to be buggy. The > structure may not be passed directly to fw_cfg interface without > endianness conversions, otherwise the emulation will not work on big > endian host. I sent a patch for this a couple days ago: http://lists.nongnu.org/archive/html/qemu-devel/2010-11/msg00481.html I think that resolves your concern. Thanks, Alex