Re: [PATCH 4/4] isigen: make number of PDP contexts configurable

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

Hi Mika,

>  plugins/isigen.c |   23 +++++++++++++++++------
>  plugins/udev.c   |    6 +++++-
>  2 files changed, 22 insertions(+), 7 deletions(-)

<snip>
 
> @@ -434,6 +434,10 @@ static void add_isi(struct ofono_modem *modem,
>  	if (addr != NULL)
>  		ofono_modem_set_integer(modem, "Address", atoi(addr));
>  
> +	pdps = get_property(udev_device, "OFONO_ISI_PDPS");
> +	if (pdps != NULL)
> +		ofono_modem_set_integer(modem, "PDPS", atoi(pdps));
> +
>  	if (g_strcmp0(udev_device_get_subsystem(udev_device), "net") != 0)
>  		return;

why to do you bother making this a configurable option? What isthe
benefit here?

Personally I think that always enabling 4 context if the hardware
supports it should be enough. If you do support more then just enable
more all the time. There are no real resources used in context of ISI
anyway. The AT command based modems have a different problem since for
most of them we need an extra TTY/DLC and an extra GAtChat object, but
ISI does not have that problem.

Regards

Marcel