All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove incorrect assert in xfs_vm_writepage
Date: Wed, 10 Nov 2010 15:48:47 -0600	[thread overview]
Message-ID: <1289425727.1925.4.camel@doink> (raw)
In-Reply-To: <20101110213911.GA11214@infradead.org>

On Wed, 2010-11-10 at 16:39 -0500, Christoph Hellwig wrote:
> In commit 20cb52ebd1b5ca6fa8a5d9b6b1392292f5ca8a45, titled
> "xfs: simplify xfs_vm_writepage" I added an assert that any !mapped
> and
> uptodate buffers are not dirty.  That asserts turns out to trigger a
> lot
> when running fsx on filesystems with small block sizes.  The reason
> for
> that is that the assert is simply incorrect.  !mapped and uptodate
> just mean this buffer covers a hole, and whenever we do a
> set_page_dirty
> we mark all blocks in the page dirty, no matter if they have data or
> not.  So remove the assert, and update the comment above the condition
> to match reality.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-11-10 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 21:39 [PATCH] xfs: remove incorrect assert in xfs_vm_writepage Christoph Hellwig
2010-11-10 21:48 ` Alex Elder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289425727.1925.4.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.