Re: [PATCH 1/2] wl1271: Prevent ad-hoc and active scanning on 11a DFS frequencies

[Luciano Coelho <luciano.coelho@nokia.com>]

On Wed, 2010-11-10 at 11:27 +0100, Oikarinen Juuso (Nokia-MS/Tampere)
wrote:
> From: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> 
> The wl1271 does not support radar detection. Hence, prevent ad-hoc and
> active scanning on frequencies requiring DFS.
> 
> Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
> ---

This looks good, except for the typo described below.

Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>


> diff --git a/drivers/net/wireless/wl12xx/wl1271_main.c b/drivers/net/wireless/wl12xx/wl1271_main.c
> index f5b1d19..eb9f821 100644
> --- a/drivers/net/wireless/wl12xx/wl1271_main.c
> +++ b/drivers/net/wireless/wl12xx/wl1271_main.c
> @@ -335,6 +335,27 @@ out:
>  	return NOTIFY_OK;
>  }
>  
> +static int wl1271_reg_notify(struct wiphy *wiphy,
> +			     struct regulatory_request *request) {
> +	struct ieee80211_supported_band *band;
> +	struct ieee80211_channel *ch;
> +	int i;
> +
> +	band = wiphy->bands[IEEE80211_BAND_5GHZ];
> +	for (i = 0; i < band->n_channels; i++) {
> +		ch = &band->channels[i];
> +		if (ch->flags % IEEE80211_CHAN_DISABLED)

Typo here, should be & instead of %.  I'll fix it myself before
applying, so no need to resend.

-- 
Cheers,
Luca.