From: Wolfgang Denk <wd@denx.de>
To: Tom Rini <trini@konsulko.com>
Cc: Heiko Thiery <heiko.thiery@gmail.com>,
u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Walle <michael@walle.cc>, Simon Glass <sjg@chromium.org>
Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails
Date: Thu, 11 Nov 2021 13:27:22 +0100 [thread overview]
Message-ID: <1289506.1636633642@gemini.denx.de> (raw)
In-Reply-To: <20211109194224.GB24579@bill-the-cat>
Dear Tom,
In message <20211109194224.GB24579@bill-the-cat> you wrote:
>
> > The only reason I want to introduce this is because I want to have my
> > imx8mq board built by CI. This board needs an external HDMI firmware
> > which is used by mkimage. But because this firmware is not available
> > in the CI build, it comes to the abort. With other boards it is also
> > so that in the CI external blobs are not available and these make
> > nevertheless without error a binman run. In this case only a warning
> > is output.
...
> Unfortunately in these days of needing multiple inputs to create a
> functional image and also needing to have CI be able to be at all
> useful, what we do in many many many cases is yell loudly to the user
> that the resulting file here will NOT work and why. So yes, some "yell
> it won't work but not return non-zero exit status" is the norm.
This is a terrible degradtion from standard programming style, then.
> I would be very much open however to some way to handle this
> differently. Some environment variable our tools check for and then
> yell-but-succeed? Some other idea? I'm just thinking out loud here.
Well, why not fix the root cause?
Heiko writes that "an external HDMI firmware" is needed - so the fix
is to provide one, or at least a dummy file which is good enough for
the build to succeed. It should be trivial to create a dummy file
in the CI context, no?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"A little knowledge is a dangerous thing." - Doug Gwyn
next prev parent reply other threads:[~2021-11-11 12:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:52 [RFC 0/2] Do not stop with an error when mkimage fails Heiko Thiery
2021-11-04 18:52 ` [RFC 1/2] patman: introduce RunException Heiko Thiery
2021-11-05 2:02 ` Simon Glass
2021-11-04 18:52 ` [RFC 2/2] binman: catch RunException for mkimage runtime failure Heiko Thiery
2021-11-05 2:02 ` Simon Glass
2021-11-05 7:49 ` Heiko Thiery
2021-11-05 16:12 ` Simon Glass
2021-11-04 19:12 ` [RFC 0/2] Do not stop with an error when mkimage fails Wolfgang Denk
2021-11-04 19:31 ` Heiko Thiery
2021-11-07 14:48 ` Wolfgang Denk
2021-11-09 19:21 ` Heiko Thiery
2021-11-09 19:42 ` Tom Rini
2021-11-10 0:18 ` Rasmus Villemoes
2021-11-10 0:26 ` Rasmus Villemoes
2021-11-10 1:37 ` Tom Rini
2021-11-10 8:28 ` Michael Walle
2021-11-10 16:31 ` Simon Glass
2021-11-11 12:29 ` Wolfgang Denk
2021-11-10 0:58 ` Simon Glass
2021-11-11 12:27 ` Wolfgang Denk [this message]
2021-11-11 15:04 ` Tom Rini
2021-11-11 12:24 ` Wolfgang Denk
2021-11-11 13:54 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289506.1636633642@gemini.denx.de \
--to=wd@denx.de \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=michael@walle.cc \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.