From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Simon Horman <horms@verge.net.au>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Urs Thuermann <urs@isnogud.escape.de>,
security@kernel.org
Subject: Re: can-bcm: fix minor heap overflow
Date: Thu, 11 Nov 2010 21:43:58 -0500 [thread overview]
Message-ID: <1289529838.3090.209.camel@Dan> (raw)
In-Reply-To: <20101112023950.GA8145@verge.net.au>
>
> If the string may be up to 17 bytes long why are you allocating 20?
>
In Oliver's defense, this doesn't matter even a little bit. The
structure will be allocated with kmalloc-1024 either way.
-Dan
next prev parent reply other threads:[~2010-11-12 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 22:10 can-bcm: fix minor heap overflow Oliver Hartkopp
2010-11-12 2:39 ` Simon Horman
2010-11-12 2:43 ` Dan Rosenberg [this message]
2010-11-12 2:48 ` Simon Horman
2010-11-12 22:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289529838.3090.209.camel@Dan \
--to=drosenberg@vsecurity.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=socketcan@hartkopp.net \
--cc=torvalds@linux-foundation.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.