From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() Date: Sat, 13 Nov 2010 13:10:34 +0200 Message-ID: <1289646634.2218.25.camel@localhost> References: <1288628129-12811-1-git-send-email-tj@kernel.org> <1288628129-12811-2-git-send-email-tj@kernel.org> <1289644735.2218.8.camel@localhost> <4CDE6BB2.5070806@kernel.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <4CDE6BB2.5070806@kernel.org> Sender: reiserfs-devel-owner@vger.kernel.org To: Tejun Heo Cc: axboe@kernel.dk, hch@infradead.org, linux-kernel@vger.kernel.org, petero2@telia.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca, tytso@mit.edu, mfasheh@suse.com, joel.becker@oracle.com, aelder@sgi.com, dm-devel@redhat.com, drbd-dev@lists.linbit.com, neilb@suse.de, leochen@broadcom.com, sbranden@broadcom.com, chris.mason@oracle.com, swhiteho@redhat.com, shaggy@linux.vnet.ibm.com, joern@logfs.org, konishi.ryusuke@lab.ntt.co.jp, reiserfs-devel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-mtd@lists.infradead.org List-Id: dm-devel.ids On Sat, 2010-11-13 at 11:42 +0100, Tejun Heo wrote: > Hmmm... not really. The patch is small enough and splitting it won't > really buy as any better bisectability. Splitting patches into > logical changes is a good thing but it's no religious dogma. Let's > apply it to the point it actually helps. Well, it is more about if your second fix is buggy, we could revert it without reverting the first fix. But anyway, this is not a big deal, so let's forget about this indeed. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9) -- To unsubscribe from this list: send the line "unsubscribe reiserfs-deve= l" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-bw0-f49.google.com ([209.85.214.49]) by canuck.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PHE0S-0002Q7-S2 for linux-mtd@lists.infradead.org; Sat, 13 Nov 2010 11:10:53 +0000 Received: by bwz5 with SMTP id 5so3949926bwz.36 for ; Sat, 13 Nov 2010 03:10:51 -0800 (PST) Subject: Re: [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() From: Artem Bityutskiy To: Tejun Heo In-Reply-To: <4CDE6BB2.5070806@kernel.org> References: <1288628129-12811-1-git-send-email-tj@kernel.org> <1288628129-12811-2-git-send-email-tj@kernel.org> <1289644735.2218.8.camel@localhost> <4CDE6BB2.5070806@kernel.org> Content-Type: text/plain; charset="UTF-8" Date: Sat, 13 Nov 2010 13:10:34 +0200 Message-ID: <1289646634.2218.25.camel@localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: jack@suse.cz, leochen@broadcom.com, neilb@suse.de, heiko.carstens@de.ibm.com, dm-devel@redhat.com, adilger.kernel@dilger.ca, konishi.ryusuke@lab.ntt.co.jp, shaggy@linux.vnet.ibm.com, drbd-dev@lists.linbit.com, joel.becker@oracle.com, hch@infradead.org, aelder@sgi.com, mfasheh@suse.com, joern@logfs.org, reiserfs-devel@vger.kernel.org, viro@zeniv.linux.org.uk, swhiteho@redhat.com, chris.mason@oracle.com, axboe@kernel.dk, tytso@mit.edu, petero2@telia.com, linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com, linux-mtd@lists.infradead.org, akpm@linux-foundation.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, 2010-11-13 at 11:42 +0100, Tejun Heo wrote: > Hmmm... not really. The patch is small enough and splitting it won't > really buy as any better bisectability. Splitting patches into > logical changes is a good thing but it's no religious dogma. Let's > apply it to the point it actually helps. Well, it is more about if your second fix is buggy, we could revert it without reverting the first fix. But anyway, this is not a big deal, so let's forget about this indeed. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060Ab0KMLKy (ORCPT ); Sat, 13 Nov 2010 06:10:54 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:46773 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474Ab0KMLKu (ORCPT ); Sat, 13 Nov 2010 06:10:50 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; b=u9FyksGJG64NKUCwEAwaWP1viOKBvBhCYkVRU0PhEVcD3S0znccffD/x7UP71cffpY WLKWhpr+VTq/iH+q0dAeZLQUL6AeM99wunDg0ai6SzZsXNHe9nKuM3cGWsJQAnD4e1mL S7umOPHaT/67T7exfkM25lE4Yz6lf9fTBX8aI= Subject: Re: [PATCH 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device() From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Tejun Heo Cc: axboe@kernel.dk, hch@infradead.org, linux-kernel@vger.kernel.org, petero2@telia.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca, tytso@mit.edu, mfasheh@suse.com, joel.becker@oracle.com, aelder@sgi.com, dm-devel@redhat.com, drbd-dev@lists.linbit.com, neilb@suse.de, leochen@broadcom.com, sbranden@broadcom.com, chris.mason@oracle.com, swhiteho@redhat.com, shaggy@linux.vnet.ibm.com, joern@logfs.org, konishi.ryusuke@lab.ntt.co.jp, reiserfs-devel@vger.kernel.org, viro@zeniv.linux.org.uk, linux-mtd@lists.infradead.org In-Reply-To: <4CDE6BB2.5070806@kernel.org> References: <1288628129-12811-1-git-send-email-tj@kernel.org> <1288628129-12811-2-git-send-email-tj@kernel.org> <1289644735.2218.8.camel@localhost> <4CDE6BB2.5070806@kernel.org> Content-Type: text/plain; charset="UTF-8" Date: Sat, 13 Nov 2010 13:10:34 +0200 Message-ID: <1289646634.2218.25.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.0 (2.32.0-2.fc14) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2010-11-13 at 11:42 +0100, Tejun Heo wrote: > Hmmm... not really. The patch is small enough and splitting it won't > really buy as any better bisectability. Splitting patches into > logical changes is a good thing but it's no religious dogma. Let's > apply it to the point it actually helps. Well, it is more about if your second fix is buggy, we could revert it without reverting the first fix. But anyway, this is not a big deal, so let's forget about this indeed. -- Best Regards, Artem Bityutskiy (Артём Битюцкий)