From: Artem Bityutskiy <dedekind1@gmail.com>
To: Matthieu CASTET <matthieu.castet@parrot.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] nand wait timeout fix
Date: Sat, 13 Nov 2010 14:13:59 +0200 [thread overview]
Message-ID: <1289650439.2218.47.camel@localhost> (raw)
In-Reply-To: <4CD149D2.5080900@parrot.com>
Matthieu,
On Wed, 2010-11-03 at 12:38 +0100, Matthieu CASTET wrote:
> nand_wait_ready timeout should not depends of HZ value.
> panic_nand_wait take an relative timeout, not a absolute one.
> warn if nand_wait exit while the nand is still busy.
>
> Signed-off-by: Matthieu CASTET <matthieu.castet@parrot.com>
could you please improve commit message so that it would explain why you
do each of the changes, which problem you solve?
...
> @@ -874,7 +874,7 @@ static int nand_wait(struct mtd_info *mtd, struct nand_chip *chip)
> chip->cmdfunc(mtd, NAND_CMD_STATUS, -1, -1);
>
> if (in_interrupt() || oops_in_progress)
> - panic_nand_wait(mtd, chip, timeo);
> + panic_nand_wait(mtd, chip, 400);
> else {
> while (time_before(jiffies, timeo)) {
> if (chip->dev_ready) {
In this cas timeo variable and its calculation can be moved to this
inner block, I suppose?
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-11-13 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 11:38 [PATCH] nand wait timeout fix Matthieu CASTET
2010-11-13 12:13 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289650439.2218.47.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=matthieu.castet@parrot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.