From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935667AbcI3FIJ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 01:08:09 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:42520 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932836AbcI3FH7 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 01:07:59 -0400
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 30 Sep 2016 10:37:57 +0530
From: kgunda@codeaurora.org
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        linux-kernel@vger.kernel.org, sboyd@codeaurora.org,
        aghayal@qti.qualcomm.com, adharmap@codeaurora.org
Subject: Re: [PATCH] spmi: regmap: enable userspace writes
In-Reply-To: <20160929180016.6tk24tltbzplzlpp@sirena.org.uk>
References: <1475148990-11272-1-git-send-email-kgunda@codeaurora.org>
 <20160929180016.6tk24tltbzplzlpp@sirena.org.uk>
Message-ID: <128966d05cff74d2da786abfb0404071@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-09-29 23:30, Mark Brown wrote:
> On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> 
>> -#undef REGMAP_ALLOW_WRITE_DEBUGFS
>> +#define REGMAP_ALLOW_WRITE_DEBUGFS
> 
> This is completely inappropriate for upstream, if you need to do
> debugging on your platform you can enable this locally but enabling
> random writes from userspace to any regmap device is really not a good
> idea for system stablity or robustness.

Sure. I will remove this change and send the next version only to update
the spmi device name.