From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Eugene Teo <eugeneteo@kernel.org>,
Kees Cook <kees.cook@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n
Date: Sat, 13 Nov 2010 13:25:21 -0500 [thread overview]
Message-ID: <1289672721.3090.349.camel@Dan> (raw)
In-Reply-To: <AANLkTi=ut2O+mCbs1jOyg-aP=E+48h1B-MH8NxK5XyVf@mail.gmail.com>
>
> Anyway, suggested replacement patch attached. Comments?
>
The desired behavior was to allow a reader with CAP_SYS_ADMIN to open
the syslog via /proc/kmsg and continue reading it even after dropping
capabilities, which is why it was placed where it was. I see no problem
with moving it back out to do_syslog, but ideally the same behavior
should be replicated.
-Dan
next prev parent reply other threads:[~2010-11-13 18:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-13 17:26 [PATCH] Fix dmesg_restrict build failure with CONFIG_EMBEDDED=y and CONFIG_PRINTK=n Joe Perches
2010-11-13 17:50 ` Linus Torvalds
2010-11-13 18:25 ` Dan Rosenberg [this message]
2010-11-13 20:22 ` Linus Torvalds
2010-11-14 3:05 ` Kees Cook
2010-11-14 12:35 ` Ingo Molnar
2010-11-13 19:51 ` Joe Perches
2010-11-13 20:01 ` Joe Perches
2010-11-13 20:31 ` Linus Torvalds
2010-11-15 1:16 ` James Morris
2010-11-15 17:04 ` Eric Paris
2010-11-15 17:34 ` Eric Paris
2010-11-15 17:41 ` Linus Torvalds
2010-11-15 17:45 ` Eric Paris
2010-11-15 18:20 ` Linus Torvalds
2010-11-15 22:13 ` James Morris
2010-11-15 22:43 ` Eric Paris
2010-11-15 22:58 ` James Morris
2010-11-15 23:08 ` Eric Paris
2010-11-15 22:16 ` James Morris
2010-11-15 22:36 ` Linus Torvalds
2010-11-15 22:51 ` James Morris
2010-11-14 2:44 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289672721.3090.349.camel@Dan \
--to=drosenberg@vsecurity.com \
--cc=akpm@linux-foundation.org \
--cc=eugeneteo@kernel.org \
--cc=joe@perches.com \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.