All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Joseph Chan <JosephChan@via.com.tw>
Subject: [PATCH] sata-via: enable magic transmission fix for vt6420
Date: Sun, 14 Nov 2010 13:31:51 +0100	[thread overview]
Message-ID: <1289737911.24491.7.camel@twins> (raw)

I was able to reproduce and test the transmission error on vt6420
hardware with the 2G WD drives. Adding the controller ID to this fix
seems to result in a properly working system.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 drivers/ata/sata_via.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 4730c42..2822492 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -577,7 +577,7 @@ static void svia_configure(struct pci_dev *pdev)
 	}
 
 	/*
-	 * vt6421 has problems talking to some drives.  The following
+	 * vt642[01] has problems talking to some drives.  The following
 	 * is the fix from Joseph Chan <JosephChan@via.com.tw>.
 	 *
 	 * When host issues HOLD, device may send up to 20DW of data
@@ -597,7 +597,7 @@ static void svia_configure(struct pci_dev *pdev)
 	 * https://bugzilla.kernel.org/show_bug.cgi?id=15173
 	 * http://article.gmane.org/gmane.linux.ide/46352
 	 */
-	if (pdev->device == 0x3249) {
+	if (pdev->device == 0x3249 || pdev->device == 0x3149) {
 		pci_read_config_byte(pdev, 0x52, &tmp8);
 		tmp8 |= 1 << 2;
 		pci_write_config_byte(pdev, 0x52, tmp8);


             reply	other threads:[~2010-11-14 12:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 12:31 Peter Zijlstra [this message]
2010-11-14 12:37 ` [PATCH] sata-via: enable magic transmission fix for vt6420 Peter Zijlstra
2010-11-15  4:02 ` Jeff Garzik
2010-11-15  9:10   ` Peter Zijlstra
2010-11-15  8:28 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1289737911.24491.7.camel@twins \
    --to=peterz@infradead.org \
    --cc=JosephChan@via.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.