diff for duplicates of <1289845457-sup-9432@think> diff --git a/a/1.txt b/N1/1.txt index df69b4e..5d6255f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,13 +4,13 @@ Excerpts from Christoph Hellwig's message of 2010-11-15 13:23:14 -0500: > > THP related at all. THP is the consumer, this is a problem in migrate > > that will trigger as well with migrate_pages or all other possible > > migration APIs. -> >=20 +> > > > If more people would be using hugetlbfs they would have noticed > > without THP. ->=20 +> > Okay, it seems THP is really just the messenger for bad VM practices > here. ->=20 +> > > +static int btree_migratepage(struct address_space *mapping, > > + struct page *newpage, struct page *page) > > +{ @@ -20,10 +20,10 @@ Excerpts from Christoph Hellwig's message of 2010-11-15 13:23:14 -0500: > > + */ > > + if (PageDirty(page)) > > + return -EAGAIN; -> >=20 +> > > > fallback_migrate_page would call writeout() which is apparently not > > ok in btrfs for locking issues leading to corruption. ->=20 +> > Hmm, it seems the issue for that particular problem is indeedin btrfs. > If it needs external locking for writing out data it should not > implement ->writepage to start with. Chris, can you explain what's @@ -34,9 +34,9 @@ Excerpts from Christoph Hellwig's message of 2010-11-15 13:23:14 -0500: > including the very weird check for for_kupdate. So, I had THP + a patched btrfs running all weekend and I can safely say -I've fixed this one now.=20 +I've fixed this one now. ->=20 +> > What's the story behing all this and the corruption that Andrea found? For the metadata blocks, btrfs gets into a problematic lock inversion @@ -81,4 +81,4 @@ To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ -Don't email: <a href=3Dmailto:"dont@kvack.org"> email@kvack.org </a> +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 95d331a..25ac616 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -23,13 +23,13 @@ "> > THP related at all. THP is the consumer, this is a problem in migrate\n" "> > that will trigger as well with migrate_pages or all other possible\n" "> > migration APIs.\n" - "> >=20\n" + "> > \n" "> > If more people would be using hugetlbfs they would have noticed\n" "> > without THP.\n" - ">=20\n" + "> \n" "> Okay, it seems THP is really just the messenger for bad VM practices\n" "> here.\n" - ">=20\n" + "> \n" "> > +static int btree_migratepage(struct address_space *mapping,\n" "> > + struct page *newpage, struct page *page)\n" "> > +{\n" @@ -39,10 +39,10 @@ "> > + */\n" "> > + if (PageDirty(page))\n" "> > + return -EAGAIN;\n" - "> >=20\n" + "> > \n" "> > fallback_migrate_page would call writeout() which is apparently not\n" "> > ok in btrfs for locking issues leading to corruption.\n" - ">=20\n" + "> \n" "> Hmm, it seems the issue for that particular problem is indeedin btrfs.\n" "> If it needs external locking for writing out data it should not\n" "> implement ->writepage to start with. Chris, can you explain what's\n" @@ -53,9 +53,9 @@ "> including the very weird check for for_kupdate.\n" "\n" "So, I had THP + a patched btrfs running all weekend and I can safely say\n" - "I've fixed this one now.=20\n" + "I've fixed this one now. \n" "\n" - ">=20\n" + "> \n" "> What's the story behing all this and the corruption that Andrea found?\n" "\n" "For the metadata blocks, btrfs gets into a problematic lock inversion\n" @@ -100,6 +100,6 @@ "the body to majordomo@kvack.org. For more info on Linux MM,\n" "see: http://www.linux-mm.org/ .\n" "Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/\n" - "Don't email: <a href=3Dmailto:\"dont@kvack.org\"> email@kvack.org </a>" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -e0e311d0e4d6b26f5b70dd62b1fd598be8e7c4767530a541dad572ee4db36492 +c20ad28ec3d05fcd770a97f8b1d4674f6f0f552ac77592336c82a5af702133df
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.