From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E095C5479D for ; Mon, 9 Jan 2023 11:07:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BC3C985144; Mon, 9 Jan 2023 12:07:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="lk/V+czV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 778ED851D3; Mon, 9 Jan 2023 12:07:20 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2044.outbound.protection.outlook.com [40.107.223.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AD82885021 for ; Mon, 9 Jan 2023 12:07:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JN6NnMaayTNnzqf4NBxPidIPwtl7xzUZHLu16oGQKm/7y+CEtqmD2qV+Pf12I785JlCj2eTJ3F9T/F3mM7mCgDio7fZfrhwX3/FzpKpjZJsfT7UAqV5aqD9ISoCBqn2NjsDZit5zRRN5EIteDAePXgR83R7P9F1bdu8rX48b9ts2ycTo3YDJfK9060NDs17t3dsT1QOsfaZilSFBWlnhxfnJ4zxuNKLLJ0i4PdTyZEKgBMCB5XDn49ftamfzofFfnCnJjpsNzLDoRLR5OhAkkh+mA5bn7cyl4alAZXoJY55iIMN+lYsPaw80qd0eSSf4u2vhCXBQufz2/dl6LvnNmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbqD5NAfFTWb9yLbRFKwQpdjAWjgdvRQwrgMuAsqGlU=; b=Y96f4cjq1ZupdOsWdYu69B/v79/F2Z5klMWlVznCALYgfVAcnvfEj53TB4oZ8JMm1vE6CSVhMh2e0h1bl2U5zE3ljX2Fd/fUIIeE6iQM1q/+Z6IUuQ8wlEOPgy1/HKWwwQ8lpP2b4TzWJsTwmD8czkUrnSjPos2nbPQKGZlpmQFJg72Y7PU+1JjXoUaearDP0uR45T7AH3x3dkXnKZDoFh8meE7X2Z9dZhDTiseuSvoJB18/OnwYrXlW7dIyNTuA/jh/krNxbI+KetXFQ8TLOIy98bKRVDAxzrAbZyBsnfh04zwSXWVjmUOEScXs6OYXDFGw3xwUxVsAujvmFEnlNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=chromium.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jbqD5NAfFTWb9yLbRFKwQpdjAWjgdvRQwrgMuAsqGlU=; b=lk/V+czVss2q6f+H3UqO/HdFhdTjytfA1hVcGf0GbgeKSVxaDKoV4LIOxAjwbfWxMuQKTJUvmgMwK2KnDuS63nnShWb0/i/4hKuC+aNCj7aetvPe82QSK4IBgbdCvvuWnUu3+Vlpna+SMxx4+avF8TNnMXvEBYmj+qPu/kTy1hg= Received: from DS7PR03CA0045.namprd03.prod.outlook.com (2603:10b6:5:3b5::20) by BN9PR12MB5036.namprd12.prod.outlook.com (2603:10b6:408:135::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 11:07:13 +0000 Received: from DS1PEPF0000E64B.namprd02.prod.outlook.com (2603:10b6:5:3b5:cafe::d9) by DS7PR03CA0045.outlook.office365.com (2603:10b6:5:3b5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 11:07:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF0000E64B.mail.protection.outlook.com (10.167.18.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6002.11 via Frontend Transport; Mon, 9 Jan 2023 11:07:13 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 9 Jan 2023 05:07:08 -0600 Message-ID: <128e89b7-db5b-a842-6990-19c52de9da22@amd.com> Date: Mon, 9 Jan 2023 12:07:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Simon Glass , Tom Rini CC: Luca Ceresoli , U-Boot Mailing List , Roger Quadros , Alper Nebi Yasak , Peter Geis , Jerome Forissier , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , Ivan Mikhaylov , Quentin Schulz , Philippe Reynes References: <20230107210721.478062-1-sjg@chromium.org> <20230107210721.478062-15-sjg@chromium.org> <20230108134132.GY3787616@bill-the-cat> <20230108160605.GB3787616@bill-the-cat> <20230108162438.GC3787616@bill-the-cat> From: Michal Simek Subject: Re: [PATCH v9 14/14] treewide: Disable USE_SPL_FIT_GENERATOR by default In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E64B:EE_|BN9PR12MB5036:EE_ X-MS-Office365-Filtering-Correlation-Id: a8d7cdef-c6ef-4bbb-4f6c-08daf231a935 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xIOGlbq0bHzxz72GXMftzKcwp6GEk8gOD0WVq7YGcu7CJ4PBEA0kou1fIvZom7YuskpCn7IwRQ8CDda7rZsQ5OQjygT5qym9KIbJzJeNscPiCp+33tJL6uGQwf4JS7Vxc3Sqdi8RQZL+cvVSlIv0lgETfjy8VhOzG0T7AxkJstBIP4fYfOWrcV9i7J/UzZnERUVWcLsSwNxEInkHUtPp7hD1uzo1FPYpB2by2bfZDlXmEmkqa5E4IuMpXTwJQk+4rsrd80teKVQFoRx262DlMmSY5CuKuA+Hs6z6EIqJ0EHPNZe4oI33MfDNXR4/XwB4pwJb6ow2B3KlfdEzMsoMH4Vi9/MfQLzlgPqrWTXc15DnXyUBst7VDVtw6u6+uK4Qx+KQFHptaVvahhjOGMQkKWARtM2n2gYZ3Yah5xsse125QaL6KE95+kKbmKIINKz+24wiGhXqbLG5GVA/8gDeyeY29EVeW1Sse/xmwCb9HZbhHE547RGpZwaSPybIf/RZVYN/mWjvpxMlrKZiWADbPrEUBOc2QtmY7zFGJf1AehuhfRk45/EfStNby/4anqyxTkUWyH6yaQXuCA8QQBspHqJzAuRNG5+kmtqak3usewTqvFnbqzG4QlzupIdEarX5cDeKBZ+DRVV5QkVMDDpiH0q17A5QMj1csW0p0DQUjr3nuISVbxwarqin3Kqs7Al9bjObmyPUojdxTweOxPuvNCY5LW8pj/AHe+04yNUjseQQK1dBDPnQbg8BICUxIcQoq7PXzDQSYxBlxOLFjmC/WA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(82310400005)(8936002)(40460700003)(2906002)(5660300002)(426003)(47076005)(41300700001)(81166007)(7416002)(16576012)(4326008)(8676002)(70586007)(70206006)(316002)(356005)(44832011)(110136005)(54906003)(186003)(16526019)(26005)(82740400003)(40480700001)(2616005)(336012)(31686004)(31696002)(83380400001)(36860700001)(86362001)(36756003)(478600001)(53546011)(6666004)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 11:07:13.1727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8d7cdef-c6ef-4bbb-4f6c-08daf231a935 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E64B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5036 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On 1/8/23 20:36, Simon Glass wrote: > Hi Tom, > > On Sun, 8 Jan 2023 at 09:24, Tom Rini wrote: >> >> On Sun, Jan 08, 2023 at 09:20:09AM -0700, Simon Glass wrote: >>> Hi Tom, >>> >>> On Sun, 8 Jan 2023 at 09:06, Tom Rini wrote: >>>> >>>> On Sun, Jan 08, 2023 at 08:48:37AM -0700, Simon Glass wrote: >>>>> Hi Tom, >>>>> >>>>> On Sun, 8 Jan 2023 at 06:41, Tom Rini wrote: >>>>>> >>>>>> On Sat, Jan 07, 2023 at 02:07:21PM -0700, Simon Glass wrote: >>>>>> >>>>>>> This option is deprecated and only used by two boards. Enable it for just >>>>>>> those two boards, so others don't accidentally enable it. >>>>>>> >>>>>>> Signed-off-by: Simon Glass >>>>>> [snip] >>>>>>> diff --git a/boot/Kconfig b/boot/Kconfig >>>>>>> index 55f06761ef8..7ab0dd14211 100644 >>>>>>> --- a/boot/Kconfig >>>>>>> +++ b/boot/Kconfig >>>>>>> @@ -282,12 +282,13 @@ config SPL_FIT_SOURCE >>>>>>> config USE_SPL_FIT_GENERATOR >>>>>>> bool "Use a script to generate the .its script" >>>>>>> depends on SPL_FIT >>>>>>> - default y if SPL_FIT && ARCH_ZYNQMP >>>>>>> + help >>>>>>> + This is deprecated. Please do not use it. Use binman instead. >>>>>> >>>>>> Lets remove the text around bool so it can't be enabled, and move to >>>>>> select'ing it from the two boards that need it. Michal, Luca, what's >>>>>> needed to move your two platforms >>>>>> (avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0 and xilinx_zynqmp_virt off >>>>>> of this very legacy option, given that other xilinx platforms have >>>>>> already migrated to binman ? >>>>> >>>>> That's a good idea, but these two boards do not have TARGET Kconfig >>>>> options so it is not possible without adding some Kconfig specific to >>>>> those boards, then defining it in the defconfig files. >>>>> >>>>> We already have the legacy warning. >>>> >>>> Yes, but I swear these are new legacy users as when we started trying to >>>> kill off this option it was just a few i.MX platforms lagging behind. >>>> >>>> Maybe make ARCH_ZYNQMP select DEPRECATED, USE_SPL_FIT_GENERATOR depend >>>> on DEPRECATED and add "DERECATED" to the end of the text line? Or maybe >>>> Michal or Luca will speak up soon and migrate these over quickly so we >>>> can just nuke this. >>> >>> Isn't that just more tortuous? I can disable SPL_LOAD_FIT on these two >>> boards since they don't appear in CI. Then they can convert them when >>> ready. >>> >>> That way we can drop the option now, if that is your goal. >> >> I thought xilinx_zynqmp_virt was in CI, but I see I'm mistaken. I still >> don't want to break platforms outright, and since it's Sunday right now >> afterall, we should let Michal and Luca a chance to catch up and chime >> in. I hope it's either going to be a quick conversion or expose >> something missing and needed in binman, as to why these still haven't >> been converted. >> > > OK let's hold off on this patch for now. It is just a clean-up anyway. First of all. ZynqMP is not wired in CI simply because we are missing some bits and pieces in upstream qemu to run it. If we can wire it with Xilinx version we can do it. I have asked to fix it our qemu team but they have never done it. In U-Boot SPL flow this script is used all the time. I use it all the time when I build work on ZynqMP. Also buildroot is using it. In connection to binman. I have looked at it 2/3 times in past. The biggest issue which I have with it is that DT node presence in DT which goes to the system. Here is example [u-boot](binman)$ make kontron_sl28_defconfig >/dev/null [u-boot](binman)$ make -j8 >/dev/null [u-boot](binman)$ dtc -I dtb -O dts dts/dt.dtb 2>/dev/null | grep binman binman { binman = "/binman"; u_boot_rom = "/binman/u-boot-rom"; where binmap is the part of target DT. It has side effects. 1. DT is bigger 2. It contains information how firmware was packed which is just additional information which don't need to be shared. 3. binman node as is placed in not documented in dt binding to be able to pass dtb check. I can call binman externally but that would mean additional build step which everybody wants to avoid. Can we update Makefile and add Kconfig option to pass configuration dtb file instead of u-boot.dtb by default? Something like: diff --git a/Makefile b/Makefile index 75a599b2c437..4d8d67c7d938 100644 --- a/Makefile +++ b/Makefile @@ -1322,7 +1322,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \ $(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \ --toolpath $(objtree)/tools \ $(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \ - build -u -d u-boot.dtb -O . -m \ + build -u -d $(CONFIG_BINMAN_CONFIG_DTB) -O . -m \ $(if $(BINMAN_ALLOW_MISSING),--allow-missing --ignore-missing) \ -I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \ -I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \ Then by default u-boot.dtb can be used or platforms can use different file. Then I would add zynqmp-binman.dts with configurations which can replace existing arch/arm/mach-zynqmp/mkimage_fit_atf.sh script. What do you think? BTW: Is there a way to generate also capsules from binman? Thanks, Michal