All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jim Keniston <jkenisto@linux.vnet.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] powerpc: fix call to subpage_protection()
Date: Fri, 19 Nov 2010 07:06:19 +1100	[thread overview]
Message-ID: <1290110779.32570.9.camel@pasglop> (raw)
In-Reply-To: <1290104610.3067.32.camel@localhost>

On Thu, 2010-11-18 at 10:23 -0800, Jim Keniston wrote:

> FWIW, this failure isn't an obstacle for me.  I'm in no way attached to
> my legacy configuration; pseries_defconfig is fine for me.  On the other
> hand, I can continue testing fixes, and/or make my system available to
> other IBMers when I'm not using it, if you want to continue to pursue
> this problem.
> 
> Thank

>From the look of it your "legacy" config is lacking the necessary
storage drivers...

Ben.

> .
> Jim
> 
> >   
> > 
> > diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> > index 83f534d..5e95844 100644
> > --- a/arch/powerpc/mm/hash_utils_64.c
> > +++ b/arch/powerpc/mm/hash_utils_64.c
> > @@ -1123,7 +1123,7 @@ void hash_preload(struct mm_struct *mm, unsigned long ea,
> >  	else
> >  #endif /* CONFIG_PPC_HAS_HASH_64K */
> >  		rc = __hash_page_4K(ea, access, vsid, ptep, trap, local, ssize,
> > -				    subpage_protection(pgdir, ea));
> > +				    subpage_protection(mm, ea));
> > 
> >  	/* Dump some info in case of hash insertion failure, they should
> >  	 * never happen so it is really useful to know if/when they do
> > 
> > 
> 

  reply	other threads:[~2010-11-18 20:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 19:54 Can't boot benh/powerpc.git kernel Jim Keniston
2010-11-10 22:06 ` Benjamin Herrenschmidt
2010-11-12  0:07   ` Jim Keniston
2010-11-12  2:29     ` Benjamin Herrenschmidt
2010-11-16  3:26     ` Michael Neuling
2010-11-17  1:51       ` Jim Keniston
2010-11-17  2:03         ` Michael Neuling
2010-11-17 19:00           ` Jim Keniston
2010-11-18  2:32             ` [PATCH] powerpc: fix call to subpage_protection() Michael Neuling
2010-11-18 12:21               ` Michael Ellerman
2010-11-18 20:24                 ` Michael Neuling
2010-11-18 21:53                   ` Michael Ellerman
2010-11-18 18:23               ` Jim Keniston
2010-11-18 20:06                 ` Benjamin Herrenschmidt [this message]
2010-11-30 11:06                   ` Milton Miller
2010-11-30 11:08                   ` Milton Miller
2010-11-30 20:55                     ` Jim Keniston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290110779.32570.9.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=jkenisto@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.