All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: eranian@google.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, acme@redhat.com,
	paulus@samba.org, davem@davemloft.net, fweisbec@gmail.com,
	perfmon2-devel@lists.sf.net, eranian@gmail.com,
	robert.richter@amd.com
Subject: Re: [PATCH] perf: add support for per-event sampling period or frequency in perf record
Date: Tue, 23 Nov 2010 12:11:20 +0100	[thread overview]
Message-ID: <1290510680.2072.390.camel@laptop> (raw)
In-Reply-To: <4ceb9b74.e6edd80a.3271.fffff742@mx.google.com>

On Tue, 2010-11-23 at 11:45 +0200, Stephane Eranian wrote:
> This patch allows specifying a per event sampling period or frequency.
> Up until now, the same sampling period or frequency was applied to all
> the events specified on the command line of perf record. A sampling 
> period depends on the event, thus it is necessary to specify it per event.
> 
> With this patch, both the -F and -c options now take a comma separated
> list of values. If a value is omitted for an event, it defaults to 1000Hz
> frequency mode as before.
> 
> $ perf record -e cycles,instructions -c 100000,200000 -a -- sleep 5


I remember an email not too long ago where people proposed to change the
syntax so that:

 -e evnt1,evnt2     -- create a group containing both events
 -e evnt1 -e evnt2  -- create two separate events

It would be nice to make sure these two proposals will not interfere.

Alternatively we extend the event syntax to include the period,
something like:

  -e evnt1:period=1234



  reply	other threads:[~2010-11-23 11:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23  9:45 [PATCH] perf: add support for per-event sampling period or frequency in perf record Stephane Eranian
2010-11-23 11:11 ` Peter Zijlstra [this message]
2010-11-23 11:33   ` Stephane Eranian
2010-11-23 11:33     ` Stephane Eranian
2010-11-23 11:42       ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290510680.2072.390.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eranian@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=perfmon2-devel@lists.sf.net \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.