From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] hid: hidpidff: Use pr_ Date: Tue, 23 Nov 2010 07:24:40 -0800 Message-ID: <1290525880.28824.17.camel@Joe-Laptop> References: <1290497701.28824.6.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.perches.com ([173.55.12.10]:1804 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754896Ab0KWPYn (ORCPT ); Tue, 23 Nov 2010 10:24:43 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 2010-11-23 at 13:36 +0100, Jiri Kosina wrote: > On Mon, 22 Nov 2010, Joe Perches wrote: > > Prefixes were not standardized in this module. > > Some used "hid-pidff:", others "hidpidff:". > > Add pr_fmt(fmt) KBUILD_MODNAME ": " fmt to standardize prefix uses. > Hmm, how about using dev_dbg instead? So that we get the bonus of having > the device name there for free? Too much restructuring required. There's no device available in many of the pr_debug uses.