From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jason Baron <jbaron@redhat.com>,
mingo@elte.hu, mathieu.desnoyers@polymtl.ca, hpa@zytor.com,
tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com,
rth@redhat.com, masami.hiramatsu.pt@hitachi.com,
fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net,
sam@ravnborg.org, ddaney@caviumnetworks.com,
michael@ellerman.id.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] jump label: updates for 2.6.37
Date: Wed, 24 Nov 2010 09:29:22 +0100 [thread overview]
Message-ID: <1290587362.2072.429.camel@laptop> (raw)
In-Reply-To: <1290553854.30543.406.camel@gandalf.stny.rr.com>
On Tue, 2010-11-23 at 18:10 -0500, Steven Rostedt wrote:
> Anyway, I just tried what you explained with the current kernel, with
> and without jump labels and, without jump labels, the module has its
> kmalloc tracepoint traced, but with jump labels it does not. So we can
> treat this as a regression, which is something that can go into an -rc.
>
> The change log must state that this _is_ a regression, or Linus may not
> accept it.
I really dislike the first patch... Preferably I'd simply fully revert
all the jump-label stuff and try again next round with a saner
interface.
There's a really good simple fix for this, simply disable the gcc
trickery for .37 and use the fallback.
Then for .38, mandate the key type to be atomic_t * and switch to the
SWITCH_POINT() interface from hpa.
next prev parent reply other threads:[~2010-11-24 8:29 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 21:27 [PATCH 0/3] jump label: updates for 2.6.37 Jason Baron
2010-11-23 21:27 ` [PATCH 1/3] jump label: add enabled/disabled state to jump label key entries Jason Baron
2010-11-23 23:43 ` Mathieu Desnoyers
2010-11-24 0:00 ` Steven Rostedt
2010-11-24 0:24 ` Mathieu Desnoyers
2010-11-24 18:24 ` Jason Baron
2010-11-24 18:39 ` Peter Zijlstra
2010-11-24 19:07 ` Jason Baron
2010-11-24 8:20 ` Peter Zijlstra
2010-11-24 14:54 ` Jason Baron
2010-11-24 15:11 ` Peter Zijlstra
2010-11-24 15:19 ` Jason Baron
2010-11-24 15:24 ` Peter Zijlstra
2010-11-24 15:42 ` Jason Baron
2010-11-24 15:53 ` Steven Rostedt
2010-11-25 2:39 ` Michael Ellerman
2010-11-25 6:52 ` Peter Zijlstra
2010-11-25 13:14 ` Mathieu Desnoyers
2010-11-25 13:42 ` Michael Ellerman
2010-11-25 21:26 ` Benjamin Herrenschmidt
2010-11-24 16:56 ` David Daney
2010-11-24 15:15 ` Steven Rostedt
2010-11-24 15:21 ` Jason Baron
2010-11-24 15:25 ` Peter Zijlstra
2010-11-24 15:57 ` Steven Rostedt
2010-11-24 19:18 ` Jason Baron
2010-11-24 15:21 ` Peter Zijlstra
2010-11-23 21:27 ` [PATCH 2/3] jump label: move jump table to r/w section Jason Baron
2010-11-23 23:55 ` Mathieu Desnoyers
2010-11-24 0:04 ` Steven Rostedt
2010-11-24 0:27 ` Mathieu Desnoyers
2010-11-24 0:35 ` Steven Rostedt
2010-11-24 2:18 ` Steven Rostedt
2010-11-24 2:59 ` Steven Rostedt
2010-11-23 21:27 ` [PATCH 3/3] jump label: add docs Jason Baron
2010-11-23 21:36 ` [PATCH 0/3] jump label: updates for 2.6.37 H. Peter Anvin
2010-11-23 23:11 ` Steven Rostedt
2010-11-23 23:32 ` H. Peter Anvin
2010-11-24 0:10 ` Steven Rostedt
2010-11-24 0:36 ` Steven Rostedt
2010-11-24 0:37 ` H. Peter Anvin
2010-11-23 21:42 ` Steven Rostedt
2010-11-23 21:56 ` Jason Baron
2010-11-23 23:10 ` Steven Rostedt
2010-11-24 8:29 ` Peter Zijlstra [this message]
2010-11-24 9:21 ` Andi Kleen
2010-11-24 12:47 ` Steven Rostedt
2010-11-24 13:49 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290587362.2072.429.camel@laptop \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=michael@ellerman.id.au \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rth@redhat.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.