From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-iscsi-target-dev@googlegroups.com
Subject: Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion
Date: Thu, 25 Nov 2010 19:46:14 +1100 [thread overview]
Message-ID: <1290674774.32570.106.camel@pasglop> (raw)
In-Reply-To: <4CECED12.5020109@suse.de>
On Wed, 2010-11-24 at 11:46 +0100, Hannes Reinecke wrote:
> >> - when a read is aborted due to a mark/EOF/EOD/EOM, the len
> reported to
> >> controller can be 0. LSI controller emulation doesn't know how to
> manage
> >> this. A workaround found is to call the completion routine with
> >> SCSI_REASON_DONE just after calling it with SCSI_REASON_DATA with
> len=0.
> >
> > Are you sure that it's not needed any more?
> >
> Don't ask me. I didn't do the patch, and my knowledge of lsi HBA
> internals is scanty.
> Nic, can you comment here?
Well, writing an HBA myself, it took me a while to figure out what I'm
supposed to expect from the layer :-)
So far tho, it appears that I can (at least with scsi-disk) rely on
always been eventually called with SCSI_REASON_DONE so my code (and
maybe the usb-msd code too, I haven't verified) relies on that to
complete requests... Is that incorrect ?
Cheers,
Ben.
next prev parent reply other threads:[~2010-11-25 8:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 8:18 [Qemu-devel] [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion Nicholas A. Bellinger
2010-11-24 8:57 ` [Qemu-devel] " Hannes Reinecke
2010-11-24 8:57 ` Nicholas A. Bellinger
2010-11-24 9:04 ` Kevin Wolf
2010-11-24 10:16 ` Hannes Reinecke
2010-11-24 10:34 ` Kevin Wolf
2010-11-24 10:46 ` Hannes Reinecke
2010-11-25 8:46 ` Benjamin Herrenschmidt [this message]
2010-11-25 8:50 ` Gerd Hoffmann
2010-11-25 9:01 ` Benjamin Herrenschmidt
2010-11-25 9:06 ` Hannes Reinecke
2010-11-25 9:07 ` Benjamin Herrenschmidt
2010-11-25 9:25 ` Gerd Hoffmann
2010-12-16 1:58 ` Benjamin Herrenschmidt
2010-11-24 10:53 ` Nicholas A. Bellinger
2010-12-21 1:49 ` Benjamin Herrenschmidt
2010-12-23 21:58 ` Nicholas A. Bellinger
2011-01-13 14:59 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290674774.32570.106.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=linux-iscsi-target-dev@googlegroups.com \
--cc=nab@linux-iscsi.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.