From: Yang Gu <yang.gu@intel.com>
To: ofono@ofono.org
Subject: [PATCH 0/3] Patch Description
Date: Thu, 25 Nov 2010 20:28:59 +0800 [thread overview]
Message-ID: <1290688142-14726-1-git-send-email-yang.gu@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]
This series of patch is to add provide local info support by requesting the terminal to send time and language info. Please comment on the following aspects as I'm not sure after reading the spec:
1. Timezone may be a number in the range -47 through +48. In struct sms_scts, timezone is defined as gint8, thus 0xFF should shand for -1, which is a valid input. Thus I think build_dataobj_datetime_timezone() in src/stkutil.c is not correct. But I'm still not sure what value should be passed to oFono when timezone is absent.
2. DBUS_TYPE_BYTE represents an 8-bit unsigned integer, and D-Bus doesn't have a type related to 8-bit signed integer. So what's the best way to represent a timezone?
3. Only one byte is used to represent the year. Is the following logic correct to get the year with one byte?
if (year_dbus >= 2000)
year = year_dbus - 2000;
else
year = year_dbus - 1900;
Yang Gu (3):
network: Use bit as size instead of byte
stk: Handle provide local info proactive command
test-stk: Add provide local info
src/network.c | 4 +-
src/smsutil.c | 6 +-
src/stk.c | 113 ++++++++++++++++++++++++++++++++++++++
src/stkagent.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++++
src/stkagent.h | 14 +++++
src/stkutil.c | 2 +-
test/test-stk-menu | 36 ++++++++++++
7 files changed, 322 insertions(+), 6 deletions(-)
--
1.7.2.3
next reply other threads:[~2010-11-25 12:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 12:28 Yang Gu [this message]
2010-11-25 12:29 ` [PATCH 1/3] network: Use bit as size instead of byte Yang Gu
2010-11-26 20:02 ` Denis Kenzior
2010-11-25 12:29 ` [PATCH 2/3] stk: Handle provide local info proactive command Yang Gu
2010-11-25 23:36 ` andrzej zaborowski
2010-11-26 20:49 ` Denis Kenzior
2010-11-29 2:47 ` Gu, Yang
2010-11-29 13:47 ` Denis Kenzior
2010-11-25 12:29 ` [PATCH 3/3] test-stk: Add provide local info Yang Gu
2010-11-25 23:25 ` [PATCH 0/3] Patch Description andrzej zaborowski
2010-11-26 3:29 ` Gu, Yang
2010-11-26 20:44 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290688142-14726-1-git-send-email-yang.gu@intel.com \
--to=yang.gu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.