From: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
To: Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pki-/L4m51SJ8HhmR6Xm/wNWPw@public.gmane.org
Subject: Re: [PATCHv2] hso: fix disable_net
Date: Thu, 25 Nov 2010 17:01:06 +0100 [thread overview]
Message-ID: <1290700866.2112.60.camel@filip-linux> (raw)
In-Reply-To: <AANLkTikODWoXB1PmB+SFbFWenYm_-o+RJ+czK9LnaXmn-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 2010-11-25 at 16:03 +0100, Johan Hovold wrote:
> On Thu, Nov 25, 2010 at 2:40 PM, Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> wrote:
> > The HSO driver incorrectly creates a serial device instead of a net
> > device when disable_net is set. It shouldn't create anything for the
> > network interface.
> >
> > Signed-off-by: Filip Aben <f.aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
>
> Please add the appropriate Reported-by-tags as well, e.g.
>
> Reported-by: Piotr Isajew <pki-/L4m51SJ8HhmR6Xm/wNWPw@public.gmane.org>
> Reported-by: Johan Hovold <jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
I would have gladly done so if you included that in your comment on the
previous patch :)
>
> As this patch is meant to fix a driver crash, perhaps it should be marked for
> stable as well?
>
I don't think it's that critical: it only applies to people explicitly
loading the module with disable_net set. But feel free to queue it up
for stable.
Thanks,
Filip-
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-25 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 13:40 [PATCHv2] hso: fix disable_net Filip Aben
2010-11-25 15:03 ` Johan Hovold
[not found] ` <AANLkTikODWoXB1PmB+SFbFWenYm_-o+RJ+czK9LnaXmn-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-25 16:01 ` Filip Aben [this message]
2010-11-25 16:25 ` Johan Hovold
2010-11-26 20:18 ` Jan Ceuleers
[not found] ` <4CF01604.9010401-bdq14YP6qtRg9hUCZPvPmw@public.gmane.org>
2010-11-28 19:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290700866.2112.60.camel@filip-linux \
--to=f.aben-x9gzzrpc1qbqt0dzr+alfa@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=jhovold-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pki-/L4m51SJ8HhmR6Xm/wNWPw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.