From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
heiko.carstens@de.ibm.com, tglx@linutronix.de, mingo@elte.hu,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH] printk: use this_cpu_{read|write} api on printk_pending
Date: Fri, 26 Nov 2010 17:29:48 +0100 [thread overview]
Message-ID: <1290788988.2145.152.camel@laptop> (raw)
In-Reply-To: <1290788536.2855.237.camel@edumazet-laptop>
On Fri, 2010-11-26 at 17:22 +0100, Eric Dumazet wrote:
> [PATCH] printk: use this_cpu_{read|write} api on printk_pending
>
> __get_cpu_var() is a bit inefficient, lets use __this_cpu_read() and
> __this_cpu_write() to manipulate printk_pending.
>
> printk_needs_cpu(cpu) is called only for the current cpu :
> Use faster __this_cpu_read().
>
> remove the redondant unlikely on (cpu_is_offline(cpu)) test
>
> # size kernel/printk.o*
> text data bss dec hex filename
> 9942 756 263488 274186 42f0a kernel/printk.o.new
> 9990 756 263488 274234 42f3a kernel/printk.o.old
Thanks, queued!
next prev parent reply other threads:[~2010-11-26 16:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 12:00 [patch 0/3] three cpu hotplug fixes Heiko Carstens
2010-11-26 12:00 ` [patch 1/3] printk: fix wake_up_klogd() vs cpu hotplug Heiko Carstens
2010-11-26 12:10 ` Peter Zijlstra
2010-11-26 12:13 ` Heiko Carstens
2010-11-26 12:15 ` Peter Zijlstra
2010-11-26 12:35 ` Eric Dumazet
2010-11-26 12:42 ` Heiko Carstens
2010-11-26 13:01 ` Eric Dumazet
2010-11-26 15:02 ` [tip:sched/urgent] printk: Fix " tip-bot for Heiko Carstens
2010-11-26 12:00 ` [patch 2/3] nohz: fix printk_needs_cpu() return value on offline cpus Heiko Carstens
2010-11-26 12:11 ` Peter Zijlstra
2010-12-07 21:32 ` [stable] " Greg KH
2010-12-08 8:07 ` Heiko Carstens
2010-12-08 11:13 ` Peter Zijlstra
2010-11-26 15:02 ` [tip:sched/urgent] nohz: Fix " tip-bot for Heiko Carstens
2010-11-26 16:22 ` [PATCH] printk: use this_cpu_{read|write} api on printk_pending Eric Dumazet
2010-11-26 16:29 ` Peter Zijlstra [this message]
2010-11-26 16:40 ` Christoph Lameter
2010-11-26 16:59 ` Eric Dumazet
2010-11-26 17:11 ` Christoph Lameter
2010-11-26 17:20 ` Eric Dumazet
2010-11-26 17:27 ` Christoph Lameter
2010-12-08 20:41 ` [tip:sched/core] printk: Use " tip-bot for Eric Dumazet
2010-12-08 21:47 ` Christoph Lameter
2010-12-09 1:43 ` Eric Dumazet
2010-12-09 23:38 ` Christoph Lameter
2010-11-26 12:01 ` [patch 3/3] nohz/s390: fix arch_needs_cpu() return value on offline cpus Heiko Carstens
2010-11-26 12:14 ` Peter Zijlstra
2010-11-26 12:17 ` Heiko Carstens
2010-12-01 9:11 ` Heiko Carstens
2010-12-01 12:19 ` Peter Zijlstra
2010-12-08 20:41 ` [tip:sched/urgent] nohz: Fix get_next_timer_interrupt() vs cpu hotplug tip-bot for Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290788988.2145.152.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.