From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932653AbdBVQQL convert rfc822-to-8bit (ORCPT ); Wed, 22 Feb 2017 11:16:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55756 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932334AbdBVQQE (ORCPT ); Wed, 22 Feb 2017 11:16:04 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1487691808-11289-2-git-send-email-elena.reshetova@intel.com> References: <1487691808-11289-2-git-send-email-elena.reshetova@intel.com> <1487691808-11289-1-git-send-email-elena.reshetova@intel.com> To: Elena Reshetova Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org, peterz@infradead.org, gregkh@linuxfoundation.org, Hans Liljestrand , Kees Cook , David Windsor Subject: Re: [PATCH 1/4] fs, afs: convert afs_cell.usage from atomic_t to refcount_t MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <12907.1487780160.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 22 Feb 2017 16:16:00 +0000 Message-ID: <12908.1487780160@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 22 Feb 2017 16:16:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Elena Reshetova wrote: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. This causes an assertion failure because cells aren't immediately destroyed when their refcount reaches 0, but may be resurrected provided the cache lock is held. However, attempting to increment the 0 refcount does nothing, not even giving a warning. So please place a hold on this patch. I will check the other AFS patches also. David